Never return undefined from getExportsOfModule (microsoft#17013)

Andy · web-flow · commit ba8e5a7e2492 · 2017-07-07T10:06:12.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -1782,7 +1782,7 @@ namespace ts {
 
         function getExportsOfModule(moduleSymbol: Symbol): SymbolTable {
             const links = getSymbolLinks(moduleSymbol);
-            return links.resolvedExports || (links.resolvedExports = getExportsForModule(moduleSymbol));
+            return links.resolvedExports || (links.resolvedExports = getExportsOfModuleWorker(moduleSymbol));
         }
 
         interface ExportCollisionTracker {
@@ -1821,13 +1821,13 @@ namespace ts {
             });
         }
 
-        function getExportsForModule(moduleSymbol: Symbol): SymbolTable {
+        function getExportsOfModuleWorker(moduleSymbol: Symbol): SymbolTable {
             const visitedSymbols: Symbol[] = [];
 
             // A module defined by an 'export=' consists on one export that needs to be resolved
             moduleSymbol = resolveExternalModuleSymbol(moduleSymbol);
 
-            return visit(moduleSymbol) || moduleSymbol.exports;
+            return visit(moduleSymbol) || emptySymbols;
 
             // The ES6 spec permits export * declarations in a module to circularly reference the module itself. For example,
             // module 'a' can 'export * from "b"' and 'b' can 'export * from "a"' without error.
diff --git a/tests/cases/fourslash/completionList_getExportsOfModule.ts b/tests/cases/fourslash/completionList_getExportsOfModule.ts
@@ -0,0 +1,16 @@
+/// <reference path='fourslash.ts'/>
+
+// This used to cause a crash because we would ask for exports on `"x"`,
+// which would return undefined and cause a NPE. Now we return emptySymbol instead.
+// See GH#16610.
+
+////declare module "x" {
+////    declare var x: number;
+////    export = x;
+////}
+////
+////let y: /**/
+
+goTo.marker();
+// This is just a dummy test to cause `getCompletionsAtPosition` to be called.
+verify.not.completionListContains("x");
