Fixed auto completion after a < token to return types not values.

dragomirtitian · dragomirtitian · commit ba79b5ffacec · 2019-07-12T23:14:42.000+03:00
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -1239,6 +1239,9 @@ namespace ts.Completions {
                     case SyntaxKind.AsKeyword:
                         return parentKind === SyntaxKind.AsExpression;
 
+                    case SyntaxKind.LessThanToken:
+                        return parentKind === SyntaxKind.TypeReference;
+
                     case SyntaxKind.ExtendsKeyword:
                         return parentKind === SyntaxKind.TypeParameter;
                 }
diff --git a/tests/cases/fourslash/completionsAfterLessThanToken.ts b/tests/cases/fourslash/completionsAfterLessThanToken.ts
@@ -0,0 +1,12 @@
+/// <reference path="fourslash.ts" />
+
+//// function f() {
+//// 	const k: Record</**/
+//// }
+
+goTo.marker();
+verify.completions({
+    includes: [
+        { name: "string", sortText: completion.SortText.GlobalsOrKeywords }
+    ]
+});
diff --git a/tests/cases/fourslash/completionsIsPossiblyTypeArgumentPosition.ts b/tests/cases/fourslash/completionsIsPossiblyTypeArgumentPosition.ts
@@ -10,8 +10,8 @@
 ////x < {| "valueOnly": true |}
 ////f < {| "valueOnly": true |}
 ////g < {| "valueOnly": false |}
-////const something: C<{| "valueOnly": false |};
-////const something2: C<C<{| "valueOnly": false |};
+////const something: C<{| "typeOnly": true |};
+////const something2: C<C<{| "typeOnly": true |};
 ////new C<{| "valueOnly": false |};
 ////new C<C<{| "valueOnly": false |};
 ////
@@ -20,7 +20,10 @@
 ////new callAndConstruct<callAndConstruct</*callAndConstruct*/
 
 for (const marker of test.markers()) {
-    if (marker.data && marker.data.valueOnly) {
+    if (marker.data && marker.data.typeOnly) {
+        verify.completions({ marker, includes: "T", excludes: "x" });
+    }
+    else if (marker.data && marker.data.valueOnly) {
         verify.completions({ marker, includes: "x", excludes: "T" });
     }
     else {

Original file line number	Diff line number	Diff line change
`@@ -1239,6 +1239,9 @@ namespace ts.Completions {`
`1239`	`1239`	`case SyntaxKind.AsKeyword:`
`1240`	`1240`	`return parentKind === SyntaxKind.AsExpression;`
`1241`	`1241`
	`1242`	`+ case SyntaxKind.LessThanToken:`
	`1243`	`+ return parentKind === SyntaxKind.TypeReference;`
	`1244`	`+`
`1242`	`1245`	`case SyntaxKind.ExtendsKeyword:`
`1243`	`1246`	`return parentKind === SyntaxKind.TypeParameter;`
`1244`	`1247`	`}`