Merge pull request microsoft#21352 from Microsoft/emitApiDiagnostics

sheetalkamat · web-flow · commit b9bb7452f80e · 2018-01-25T08:56:59.000-08:00
Expose sort and deduplicate diagnostics in Public API
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -16,6 +16,10 @@ namespace ts {
         // Update: We also consider a path like `C:\foo.ts` "relative" because we do not search for it in `node_modules` or treat it as an ambient module.
         return pathIsRelative(moduleName) || isRootedDiskPath(moduleName);
     }
+
+    export function sortAndDeduplicateDiagnostics(diagnostics: ReadonlyArray<Diagnostic>): Diagnostic[] {
+        return sortAndDeduplicate(diagnostics, compareDiagnostics);
+    }
 }
 
 /* @internal */
@@ -1901,10 +1905,6 @@ namespace ts {
         return text1 ? Comparison.GreaterThan : Comparison.LessThan;
     }
 
-    export function sortAndDeduplicateDiagnostics(diagnostics: ReadonlyArray<Diagnostic>): Diagnostic[] {
-        return sortAndDeduplicate(diagnostics, compareDiagnostics);
-    }
-
     export function normalizeSlashes(path: string): string {
         return path.replace(/\\/g, "/");
     }
diff --git a/tests/baselines/reference/api/tsserverlibrary.d.ts b/tests/baselines/reference/api/tsserverlibrary.d.ts
@@ -2814,6 +2814,7 @@ declare namespace ts {
 }
 declare namespace ts {
     function isExternalModuleNameRelative(moduleName: string): boolean;
+    function sortAndDeduplicateDiagnostics(diagnostics: ReadonlyArray<Diagnostic>): Diagnostic[];
 }
 declare function setTimeout(handler: (...args: any[]) => void, timeout: number): any;
 declare function clearTimeout(handle: any): void;
diff --git a/tests/baselines/reference/api/typescript.d.ts b/tests/baselines/reference/api/typescript.d.ts
@@ -2814,6 +2814,7 @@ declare namespace ts {
 }
 declare namespace ts {
     function isExternalModuleNameRelative(moduleName: string): boolean;
+    function sortAndDeduplicateDiagnostics(diagnostics: ReadonlyArray<Diagnostic>): Diagnostic[];
 }
 declare function setTimeout(handler: (...args: any[]) => void, timeout: number): any;
 declare function clearTimeout(handle: any): void;

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,10 @@ namespace ts {`
`16`	`16`	// Update: We also consider a path like `C:\foo.ts` "relative" because we do not search for it in `node_modules` or treat it as an ambient module.
`17`	`17`	`return pathIsRelative(moduleName) \|\| isRootedDiskPath(moduleName);`
`18`	`18`	`}`
	`19`	`+`
	`20`	`+ export function sortAndDeduplicateDiagnostics(diagnostics: ReadonlyArray<Diagnostic>): Diagnostic[] {`
	`21`	`+ return sortAndDeduplicate(diagnostics, compareDiagnostics);`
	`22`	`+ }`
`19`	`23`	`}`
`20`	`24`
`21`	`25`	`/* @internal */`
`@@ -1901,10 +1905,6 @@ namespace ts {`
`1901`	`1905`	`return text1 ? Comparison.GreaterThan : Comparison.LessThan;`
`1902`	`1906`	`}`
`1903`	`1907`
`1904`		`- export function sortAndDeduplicateDiagnostics(diagnostics: ReadonlyArray<Diagnostic>): Diagnostic[] {`
`1905`		`- return sortAndDeduplicate(diagnostics, compareDiagnostics);`
`1906`		`- }`
`1907`		`-`
`1908`	`1908`	`export function normalizeSlashes(path: string): string {`
`1909`	`1909`	`return path.replace(/\\/g, "/");`
`1910`	`1910`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2814,6 +2814,7 @@ declare namespace ts {`
`2814`	`2814`	`}`
`2815`	`2815`	`declare namespace ts {`
`2816`	`2816`	`function isExternalModuleNameRelative(moduleName: string): boolean;`
	`2817`	`+ function sortAndDeduplicateDiagnostics(diagnostics: ReadonlyArray<Diagnostic>): Diagnostic[];`
`2817`	`2818`	`}`
`2818`	`2819`	`declare function setTimeout(handler: (...args: any[]) => void, timeout: number): any;`
`2819`	`2820`	`declare function clearTimeout(handle: any): void;`