Merge branch 'master' of https://github.com/Microsoft/TypeScript

Lazarus535 · Lazarus535 · commit b9a2d7f0efc9 · 2018-01-22T21:47:12.000+01:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -5995,7 +5995,9 @@ namespace ts {
             for (const memberType of types) {
                 for (const { escapedName } of getAugmentedPropertiesOfType(memberType)) {
                     if (!props.has(escapedName)) {
-                        props.set(escapedName, createUnionOrIntersectionProperty(unionType as UnionType, escapedName));
+                        const prop = createUnionOrIntersectionProperty(unionType as UnionType, escapedName);
+                        // May be undefined if the property is private
+                        if (prop) props.set(escapedName, prop);
                     }
                 }
             }
@@ -6177,7 +6179,7 @@ namespace ts {
                 t;
         }
 
-        function createUnionOrIntersectionProperty(containingType: UnionOrIntersectionType, name: __String): Symbol {
+        function createUnionOrIntersectionProperty(containingType: UnionOrIntersectionType, name: __String): Symbol | undefined {
             let props: Symbol[];
             const isUnion = containingType.flags & TypeFlags.Union;
             const excludeModifiers = isUnion ? ModifierFlags.NonPublicAccessibilityModifier : 0;
diff --git a/src/harness/externalCompileRunner.ts b/src/harness/externalCompileRunner.ts
@@ -131,13 +131,13 @@ function removeExpectedErrors(errors: string, cwd: string): string {
 function isUnexpectedError(cwd: string) {
     return (error: string[]) => {
         ts.Debug.assertGreaterThanOrEqual(error.length, 1);
-        const match = error[0].match(/(.+\.ts)\((\d+),\d+\): error TS/);
+        const match = error[0].match(/(.+\.tsx?)\((\d+),\d+\): error TS/);
         if (!match) {
             return true;
         }
         const [, errorFile, lineNumberString] = match;
         const lines = fs.readFileSync(path.join(cwd, errorFile), { encoding: "utf8" }).split("\n");
-        const lineNumber = parseInt(lineNumberString);
+        const lineNumber = parseInt(lineNumberString) - 1;
         ts.Debug.assertGreaterThanOrEqual(lineNumber, 0);
         ts.Debug.assertLessThan(lineNumber, lines.length);
         const previousLine = lineNumber - 1 > 0 ? lines[lineNumber - 1] : "";
diff --git a/tests/cases/fourslash/completionsUnion.ts b/tests/cases/fourslash/completionsUnion.ts
@@ -2,7 +2,9 @@
 
 ////interface I { x: number; }
 ////interface Many<T> extends ReadonlyArray<T> { extra: number; }
-////const x: I | I[] | Many<string> = { /**/ };
+////class C { private priv: number; }
+////const x: I | I[] | Many<string> | C = { /**/ };
 
 // We specifically filter out any array-like types.
+// Private members will be excluded by `createUnionOrIntersectionProperty`.
 verify.completionsAt("", ["x"]);

Original file line number	Diff line number	Diff line change
`@@ -5995,7 +5995,9 @@ namespace ts {`
`5995`	`5995`	`for (const memberType of types) {`
`5996`	`5996`	`for (const { escapedName } of getAugmentedPropertiesOfType(memberType)) {`
`5997`	`5997`	`if (!props.has(escapedName)) {`
`5998`		`- props.set(escapedName, createUnionOrIntersectionProperty(unionType as UnionType, escapedName));`
	`5998`	`+ const prop = createUnionOrIntersectionProperty(unionType as UnionType, escapedName);`
	`5999`	`+ // May be undefined if the property is private`
	`6000`	`+ if (prop) props.set(escapedName, prop);`
`5999`	`6001`	`}`
`6000`	`6002`	`}`
`6001`	`6003`	`}`
`@@ -6177,7 +6179,7 @@ namespace ts {`
`6177`	`6179`	`t;`
`6178`	`6180`	`}`
`6179`	`6181`
`6180`		`- function createUnionOrIntersectionProperty(containingType: UnionOrIntersectionType, name: __String): Symbol {`
	`6182`	`+ function createUnionOrIntersectionProperty(containingType: UnionOrIntersectionType, name: __String): Symbol \| undefined {`
`6181`	`6183`	`let props: Symbol[];`
`6182`	`6184`	`const isUnion = containingType.flags & TypeFlags.Union;`
`6183`	`6185`	`const excludeModifiers = isUnion ? ModifierFlags.NonPublicAccessibilityModifier : 0;`