Harden compilerRunner vs rooted path names in tests (microsoft#9714)

weswigham · web-flow · commit b8e814e9a4b4 · 2016-07-14T10:30:37.000-07:00
* Harden compilerRunner vs rooted path names in tests

* Call toPath on currentDirectory
diff --git a/src/harness/compilerRunner.ts b/src/harness/compilerRunner.ts
@@ -50,7 +50,9 @@ class CompilerBaselineRunner extends RunnerBase {
     }
 
     private makeUnitName(name: string, root: string) {
-        return ts.isRootedDiskPath(name) ? name : ts.combinePaths(root, name);
+        const path = ts.toPath(name, root, (fileName) => Harness.Compiler.getCanonicalFileName(fileName));
+        const pathStart = ts.toPath(Harness.IO.getCurrentDirectory(), "", (fileName) => Harness.Compiler.getCanonicalFileName(fileName));
+        return path.replace(pathStart, "/");
     };
 
     public checkTestCodeOutput(fileName: string) {

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,9 @@ class CompilerBaselineRunner extends RunnerBase {`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`private makeUnitName(name: string, root: string) {`
`53`		`- return ts.isRootedDiskPath(name) ? name : ts.combinePaths(root, name);`
	`53`	`+ const path = ts.toPath(name, root, (fileName) => Harness.Compiler.getCanonicalFileName(fileName));`
	`54`	`+ const pathStart = ts.toPath(Harness.IO.getCurrentDirectory(), "", (fileName) => Harness.Compiler.getCanonicalFileName(fileName));`
	`55`	`+ return path.replace(pathStart, "/");`
`54`	`56`	`};`
`55`	`57`
`56`	`58`	`public checkTestCodeOutput(fileName: string) {`