Set syntheticLiteralTypeOrigin on synthetic undefined-type members (microsoft#22216)

weswigham · web-flow · commit b8e0009c9b59 · 2018-02-28T16:03:05.000-08:00
* Have getNameOfSymbolAsWritten quote nonidentifier nonnumeric symbols all the time

* Revert checker changes

* Reuse synthetic origin to indicate that derived declaration name may need to be quoted
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -11150,6 +11150,10 @@ namespace ts {
             }
             const result = createSymbol(SymbolFlags.Property | SymbolFlags.Optional, name);
             result.type = undefinedType;
+            const associatedKeyType = getLiteralType(unescapeLeadingUnderscores(name));
+            if (associatedKeyType.flags & TypeFlags.StringLiteral) {
+                result.syntheticLiteralTypeOrigin = associatedKeyType as StringLiteralType;
+            }
             undefinedProperties.set(name, result);
             return result;
         }
diff --git a/tests/baselines/reference/inferredNonidentifierTypesGetQuotes.js b/tests/baselines/reference/inferredNonidentifierTypesGetQuotes.js
@@ -0,0 +1,22 @@
+//// [inferredNonidentifierTypesGetQuotes.ts]
+var x = [{ "a-b": "string" }, {}];
+
+var y = [{ ["a-b"]: "string" }, {}];
+
+//// [inferredNonidentifierTypesGetQuotes.js]
+var x = [{ "a-b": "string" }, {}];
+var y = [(_a = {}, _a["a-b"] = "string", _a), {}];
+var _a;
+
+
+//// [inferredNonidentifierTypesGetQuotes.d.ts]
+declare var x: ({
+    "a-b": string;
+} | {
+    "a-b"?: undefined;
+})[];
+declare var y: ({
+    ["a-b"]: string;
+} | {
+    "a-b"?: undefined;
+})[];
diff --git a/tests/baselines/reference/inferredNonidentifierTypesGetQuotes.symbols b/tests/baselines/reference/inferredNonidentifierTypesGetQuotes.symbols
@@ -0,0 +1,10 @@
+=== tests/cases/compiler/inferredNonidentifierTypesGetQuotes.ts ===
+var x = [{ "a-b": "string" }, {}];
+>x : Symbol(x, Decl(inferredNonidentifierTypesGetQuotes.ts, 0, 3))
+>"a-b" : Symbol("a-b", Decl(inferredNonidentifierTypesGetQuotes.ts, 0, 10))
+
+var y = [{ ["a-b"]: "string" }, {}];
+>y : Symbol(y, Decl(inferredNonidentifierTypesGetQuotes.ts, 2, 3))
+>["a-b"] : Symbol(["a-b"], Decl(inferredNonidentifierTypesGetQuotes.ts, 2, 10))
+>"a-b" : Symbol(["a-b"], Decl(inferredNonidentifierTypesGetQuotes.ts, 2, 10))
+
diff --git a/tests/baselines/reference/inferredNonidentifierTypesGetQuotes.types b/tests/baselines/reference/inferredNonidentifierTypesGetQuotes.types
@@ -0,0 +1,18 @@
+=== tests/cases/compiler/inferredNonidentifierTypesGetQuotes.ts ===
+var x = [{ "a-b": "string" }, {}];
+>x : ({ "a-b": string; } | { "a-b"?: undefined; })[]
+>[{ "a-b": "string" }, {}] : ({ "a-b": string; } | {})[]
+>{ "a-b": "string" } : { "a-b": string; }
+>"a-b" : string
+>"string" : "string"
+>{} : {}
+
+var y = [{ ["a-b"]: "string" }, {}];
+>y : ({ ["a-b"]: string; } | { "a-b"?: undefined; })[]
+>[{ ["a-b"]: "string" }, {}] : ({ ["a-b"]: string; } | {})[]
+>{ ["a-b"]: "string" } : { ["a-b"]: string; }
+>["a-b"] : string
+>"a-b" : "a-b"
+>"string" : "string"
+>{} : {}
+
diff --git a/tests/cases/compiler/inferredNonidentifierTypesGetQuotes.ts b/tests/cases/compiler/inferredNonidentifierTypesGetQuotes.ts
@@ -0,0 +1,4 @@
+// @declaration: true
+var x = [{ "a-b": "string" }, {}];
+
+var y = [{ ["a-b"]: "string" }, {}];

Original file line number	Diff line number	Diff line change
`@@ -11150,6 +11150,10 @@ namespace ts {`
`11150`	`11150`	`}`
`11151`	`11151`	`const result = createSymbol(SymbolFlags.Property \| SymbolFlags.Optional, name);`
`11152`	`11152`	`result.type = undefinedType;`
	`11153`	`+ const associatedKeyType = getLiteralType(unescapeLeadingUnderscores(name));`
	`11154`	`+ if (associatedKeyType.flags & TypeFlags.StringLiteral) {`
	`11155`	`+ result.syntheticLiteralTypeOrigin = associatedKeyType as StringLiteralType;`
	`11156`	`+ }`
`11153`	`11157`	`undefinedProperties.set(name, result);`
`11154`	`11158`	`return result;`
`11155`	`11159`	`}`