Fix wrong condition for unterminated multi-line comments

mhegazy · mhegazy · commit b6f4aa9da905 · 2014-10-23T14:08:04.000-07:00
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -2025,9 +2025,9 @@ module ts {
                         return true;
                     }
                     else {
-                        // is unterminated multiline comment
-                        return text.charCodeAt(comment.end - 1) !== CharacterCodes.slash &&
-                            text.charCodeAt(comment.end - 2) !== CharacterCodes.asterisk;
+                        // is unterminated multi-line comment
+                        return !(text.charCodeAt(comment.end - 1) === CharacterCodes.slash &&
+                            text.charCodeAt(comment.end - 2) === CharacterCodes.asterisk);
                     }
                 }
                 return false;
diff --git a/tests/cases/fourslash/completionListInComments3.ts b/tests/cases/fourslash/completionListInComments3.ts
@@ -10,6 +10,8 @@
 
 //// {| "name": "5" |}/*  */
 
+/////* {| "name": "6" |}
+
 goTo.marker("1");
 verify.completionListIsEmpty();
 
@@ -22,5 +24,8 @@ verify.completionListIsEmpty();
 goTo.marker("4");
 verify.not.completionListIsEmpty();
 
-//goTo.marker("5");
-//verify.not.completionListIsEmpty();
+goTo.marker("5");
+verify.not.completionListIsEmpty();
+
+goTo.marker("6");
+verify.completionListIsEmpty();

Original file line number	Diff line number	Diff line change
`@@ -2025,9 +2025,9 @@ module ts {`
`2025`	`2025`	`return true;`
`2026`	`2026`	`}`
`2027`	`2027`	`else {`
`2028`		`- // is unterminated multiline comment`
`2029`		`- return text.charCodeAt(comment.end - 1) !== CharacterCodes.slash &&`
`2030`		`- text.charCodeAt(comment.end - 2) !== CharacterCodes.asterisk;`
	`2028`	`+ // is unterminated multi-line comment`
	`2029`	`+ return !(text.charCodeAt(comment.end - 1) === CharacterCodes.slash &&`
	`2030`	`+ text.charCodeAt(comment.end - 2) === CharacterCodes.asterisk);`
`2031`	`2031`	`}`
`2032`	`2032`	`}`
`2033`	`2033`	`return false;`