Update based on feedback

sheetalkamat · sheetalkamat · commit b66b7525617e · 2017-08-18T11:15:42.000-07:00
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -2736,7 +2736,7 @@ namespace ts {
         function fileExists(fileName: string): boolean {
             const path = toPath(fileName);
             const result = getCachedFileSystemEntriesForBaseDir(path);
-            return (result && hasEntry(result.files, getBaseNameOfFileName(fileName))) ||
+            return result && hasEntry(result.files, getBaseNameOfFileName(fileName)) ||
                 host.fileExists(fileName);
         }
 
diff --git a/src/compiler/sys.ts b/src/compiler/sys.ts
@@ -30,6 +30,9 @@ namespace ts {
         mtime?: Date;
     }
 
+    /**
+     * Partial interface of the System thats needed to support the caching of directory structure
+     */
     export interface PartialSystem {
         writeFile(path: string, data: string, writeByteOrderMark?: boolean): void;
         fileExists(path: string): boolean;
diff --git a/src/harness/unittests/programMissingFiles.ts b/src/harness/unittests/programMissingFiles.ts
@@ -3,7 +3,7 @@
 namespace ts {
     function verifyMissingFilePaths(missingPaths: ReadonlyArray<Path>, expected: ReadonlyArray<string>) {
         assert.isDefined(missingPaths);
-        const map = arrayToMap(expected, k => k, _v => true);
+        const map = arrayToSet(expected) as Map<boolean>;
         for (const missing of missingPaths) {
             const value = map.get(missing);
             assert.isTrue(value, `${missing} to be ${value === undefined ? "not present" : "present only once"}, in actual: ${missingPaths} expected: ${expected}`);

Original file line number	Diff line number	Diff line change
`@@ -2736,7 +2736,7 @@ namespace ts {`
`2736`	`2736`	`function fileExists(fileName: string): boolean {`
`2737`	`2737`	`const path = toPath(fileName);`
`2738`	`2738`	`const result = getCachedFileSystemEntriesForBaseDir(path);`
`2739`		`- return (result && hasEntry(result.files, getBaseNameOfFileName(fileName))) \|\|`
	`2739`	`+ return result && hasEntry(result.files, getBaseNameOfFileName(fileName)) \|\|`
`2740`	`2740`	`host.fileExists(fileName);`
`2741`	`2741`	`}`
`2742`	`2742`
Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,9 @@ namespace ts {`
`30`	`30`	`mtime?: Date;`
`31`	`31`	`}`
`32`	`32`
	`33`	`+ /**`
	`34`	`+ * Partial interface of the System thats needed to support the caching of directory structure`
	`35`	`+ */`
`33`	`36`	`export interface PartialSystem {`
`34`	`37`	`writeFile(path: string, data: string, writeByteOrderMark?: boolean): void;`
`35`	`38`	`fileExists(path: string): boolean;`