No assert for nameless typedefs (microsoft#26695)

sandersn · web-flow · commit b50c37de785a · 2018-08-27T14:12:14.000-07:00
The assert is over-optimistic and should be removed until we can parse every possible thing that people might put in a JSDoc type position. Fixes microsoft#26693
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -4853,13 +4853,13 @@ namespace ts {
         if (isDeclaration(hostNode)) {
             return getDeclarationIdentifier(hostNode);
         }
-        // Covers remaining cases
+        // Covers remaining cases (returning undefined if none match).
         switch (hostNode.kind) {
             case SyntaxKind.VariableStatement:
                 if (hostNode.declarationList && hostNode.declarationList.declarations[0]) {
                     return getDeclarationIdentifier(hostNode.declarationList.declarations[0]);
                 }
-                return undefined;
+                break;
             case SyntaxKind.ExpressionStatement:
                 const expr = hostNode.expression;
                 switch (expr.kind) {
@@ -4871,20 +4871,16 @@ namespace ts {
                             return arg;
                         }
                 }
-                return undefined;
-            case SyntaxKind.EndOfFileToken:
-                return undefined;
+                break;
             case SyntaxKind.ParenthesizedExpression: {
                 return getDeclarationIdentifier(hostNode.expression);
             }
             case SyntaxKind.LabeledStatement: {
                 if (isDeclaration(hostNode.statement) || isExpression(hostNode.statement)) {
                     return getDeclarationIdentifier(hostNode.statement);
                 }
-                return undefined;
+                break;
             }
-            default:
-                Debug.assertNever(hostNode, "Found typedef tag attached to node which it should not be!");
         }
     }
 
diff --git a/tests/baselines/reference/noAssertForUnparseableTypedefs.errors.txt b/tests/baselines/reference/noAssertForUnparseableTypedefs.errors.txt
@@ -0,0 +1,15 @@
+tests/cases/conformance/jsdoc/bug26693.js(1,15): error TS2304: Cannot find name 'module'.
+tests/cases/conformance/jsdoc/bug26693.js(1,21): error TS1005: '}' expected.
+tests/cases/conformance/jsdoc/bug26693.js(2,22): error TS2307: Cannot find module 'nope'.
+
+
+==== tests/cases/conformance/jsdoc/bug26693.js (3 errors) ====
+    /** @typedef {module:locale} hi */
+                  ~~~~~~
+!!! error TS2304: Cannot find name 'module'.
+                        ~
+!!! error TS1005: '}' expected.
+    import { nope } from 'nope';
+                         ~~~~~~
+!!! error TS2307: Cannot find module 'nope'.
+    
diff --git a/tests/baselines/reference/noAssertForUnparseableTypedefs.symbols b/tests/baselines/reference/noAssertForUnparseableTypedefs.symbols
@@ -0,0 +1,5 @@
+=== tests/cases/conformance/jsdoc/bug26693.js ===
+/** @typedef {module:locale} hi */
+import { nope } from 'nope';
+>nope : Symbol(nope, Decl(bug26693.js, 1, 8))
+
diff --git a/tests/baselines/reference/noAssertForUnparseableTypedefs.types b/tests/baselines/reference/noAssertForUnparseableTypedefs.types
@@ -0,0 +1,5 @@
+=== tests/cases/conformance/jsdoc/bug26693.js ===
+/** @typedef {module:locale} hi */
+import { nope } from 'nope';
+>nope : any
+
diff --git a/tests/cases/conformance/jsdoc/noAssertForUnparseableTypedefs.ts b/tests/cases/conformance/jsdoc/noAssertForUnparseableTypedefs.ts
@@ -0,0 +1,7 @@
+// @noEmit: true
+// @allowJs: true
+// @checkJs: true
+// @Filename: bug26693.js
+
+/** @typedef {module:locale} hi */
+import { nope } from 'nope';

Original file line number	Diff line number	Diff line change
`@@ -4853,13 +4853,13 @@ namespace ts {`
`4853`	`4853`	`if (isDeclaration(hostNode)) {`
`4854`	`4854`	`return getDeclarationIdentifier(hostNode);`
`4855`	`4855`	`}`
`4856`		`- // Covers remaining cases`
	`4856`	`+ // Covers remaining cases (returning undefined if none match).`
`4857`	`4857`	`switch (hostNode.kind) {`
`4858`	`4858`	`case SyntaxKind.VariableStatement:`
`4859`	`4859`	`if (hostNode.declarationList && hostNode.declarationList.declarations[0]) {`
`4860`	`4860`	`return getDeclarationIdentifier(hostNode.declarationList.declarations[0]);`
`4861`	`4861`	`}`
`4862`		`- return undefined;`
	`4862`	`+ break;`
`4863`	`4863`	`case SyntaxKind.ExpressionStatement:`
`4864`	`4864`	`const expr = hostNode.expression;`
`4865`	`4865`	`switch (expr.kind) {`
`@@ -4871,20 +4871,16 @@ namespace ts {`
`4871`	`4871`	`return arg;`
`4872`	`4872`	`}`
`4873`	`4873`	`}`
`4874`		`- return undefined;`
`4875`		`- case SyntaxKind.EndOfFileToken:`
`4876`		`- return undefined;`
	`4874`	`+ break;`
`4877`	`4875`	`case SyntaxKind.ParenthesizedExpression: {`
`4878`	`4876`	`return getDeclarationIdentifier(hostNode.expression);`
`4879`	`4877`	`}`
`4880`	`4878`	`case SyntaxKind.LabeledStatement: {`
`4881`	`4879`	`if (isDeclaration(hostNode.statement) \|\| isExpression(hostNode.statement)) {`
`4882`	`4880`	`return getDeclarationIdentifier(hostNode.statement);`
`4883`	`4881`	`}`
`4884`		`- return undefined;`
	`4882`	`+ break;`
`4885`	`4883`	`}`
`4886`		`- default:`
`4887`		`- Debug.assertNever(hostNode, "Found typedef tag attached to node which it should not be!");`
`4888`	`4884`	`}`
`4889`	`4885`	`}`
`4890`	`4886`