Use getInternalName not getLocalName (microsoft#20168)

weswigham · web-flow · commit b2f2610b8524 · 2018-01-08T13:55:50.000-08:00
diff --git a/src/compiler/transformers/es2015.ts b/src/compiler/transformers/es2015.ts
@@ -859,7 +859,7 @@ namespace ts {
                 statements.push(
                     setTextRange(
                         createStatement(
-                            createExtendsHelper(context, getLocalName(node))
+                            createExtendsHelper(context, getInternalName(node))
                         ),
                         /*location*/ extendsClauseElement
                     )
diff --git a/tests/baselines/reference/classExtensionNameOutput.js b/tests/baselines/reference/classExtensionNameOutput.js
@@ -0,0 +1,38 @@
+//// [classExtensionNameOutput.ts]
+class A {}
+if (true) {
+  class B extends A {}
+
+  const foo = function () {
+    new B();
+  }
+}
+
+//// [classExtensionNameOutput.js]
+var __extends = (this && this.__extends) || (function () {
+    var extendStatics = Object.setPrototypeOf ||
+        ({ __proto__: [] } instanceof Array && function (d, b) { d.__proto__ = b; }) ||
+        function (d, b) { for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p]; };
+    return function (d, b) {
+        extendStatics(d, b);
+        function __() { this.constructor = d; }
+        d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
+    };
+})();
+var A = /** @class */ (function () {
+    function A() {
+    }
+    return A;
+}());
+if (true) {
+    var B_1 = /** @class */ (function (_super) {
+        __extends(B, _super);
+        function B() {
+            return _super !== null && _super.apply(this, arguments) || this;
+        }
+        return B;
+    }(A));
+    var foo = function () {
+        new B_1();
+    };
+}
diff --git a/tests/baselines/reference/classExtensionNameOutput.symbols b/tests/baselines/reference/classExtensionNameOutput.symbols
@@ -0,0 +1,16 @@
+=== tests/cases/compiler/classExtensionNameOutput.ts ===
+class A {}
+>A : Symbol(A, Decl(classExtensionNameOutput.ts, 0, 0))
+
+if (true) {
+  class B extends A {}
+>B : Symbol(B, Decl(classExtensionNameOutput.ts, 1, 11))
+>A : Symbol(A, Decl(classExtensionNameOutput.ts, 0, 0))
+
+  const foo = function () {
+>foo : Symbol(foo, Decl(classExtensionNameOutput.ts, 4, 7))
+
+    new B();
+>B : Symbol(B, Decl(classExtensionNameOutput.ts, 1, 11))
+  }
+}
diff --git a/tests/baselines/reference/classExtensionNameOutput.types b/tests/baselines/reference/classExtensionNameOutput.types
@@ -0,0 +1,20 @@
+=== tests/cases/compiler/classExtensionNameOutput.ts ===
+class A {}
+>A : A
+
+if (true) {
+>true : true
+
+  class B extends A {}
+>B : B
+>A : A
+
+  const foo = function () {
+>foo : () => void
+>function () {    new B();  } : () => void
+
+    new B();
+>new B() : B
+>B : typeof B
+  }
+}
diff --git a/tests/cases/compiler/classExtensionNameOutput.ts b/tests/cases/compiler/classExtensionNameOutput.ts
@@ -0,0 +1,8 @@
+class A {}
+if (true) {
+  class B extends A {}
+
+  const foo = function () {
+    new B();
+  }
+}

Original file line number	Diff line number	Diff line change
`@@ -859,7 +859,7 @@ namespace ts {`
`859`	`859`	`statements.push(`
`860`	`860`	`setTextRange(`
`861`	`861`	`createStatement(`
`862`		`- createExtendsHelper(context, getLocalName(node))`
	`862`	`+ createExtendsHelper(context, getInternalName(node))`
`863`	`863`	`),`
`864`	`864`	`/location/ extendsClauseElement`
`865`	`865`	`)`