Add undefined to return type

uniqueiniquity · uniqueiniquity · commit b1b611f40adc · 2017-11-02T11:08:26.000-07:00
diff --git a/src/harness/harnessLanguageService.ts b/src/harness/harnessLanguageService.ts
@@ -492,7 +492,7 @@ namespace Harness.LanguageService {
         getFormattingEditsAfterKeystroke(fileName: string, position: number, key: string, options: ts.FormatCodeOptions): ts.TextChange[] {
             return unwrapJSONCallResult(this.shim.getFormattingEditsAfterKeystroke(fileName, position, key, JSON.stringify(options)));
         }
-        getDocCommentTemplateAtPosition(fileName: string, position: number): ts.TextInsertion {
+        getDocCommentTemplateAtPosition(fileName: string, position: number): ts.TextInsertion | undefined {
             return unwrapJSONCallResult(this.shim.getDocCommentTemplateAtPosition(fileName, position));
         }
         isValidBraceCompletionAtPosition(fileName: string, position: number, openingBrace: number): boolean {
diff --git a/src/services/jsDoc.ts b/src/services/jsDoc.ts
@@ -189,7 +189,8 @@ namespace ts.JsDoc {
      * @param position The (character-indexed) position in the file where the check should
      * be performed.
      */
-    export function getDocCommentTemplateAtPosition(newLine: string, sourceFile: SourceFile, position: number): TextInsertion {
+
+    export function getDocCommentTemplateAtPosition(newLine: string, sourceFile: SourceFile, position: number): TextInsertion | undefined {
         // Check if in a context where we don't want to perform any insertion
         if (isInString(sourceFile, position) || isInComment(sourceFile, position) || hasDocComment(sourceFile, position)) {
             return undefined;
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -1791,7 +1791,7 @@ namespace ts {
             }
         }
 
-        function getDocCommentTemplateAtPosition(fileName: string, position: number): TextInsertion {
+        function getDocCommentTemplateAtPosition(fileName: string, position: number): TextInsertion | undefined {
             return JsDoc.getDocCommentTemplateAtPosition(getNewLineOrDefaultFromHost(host), syntaxTreeCache.getCurrentSourceFile(fileName), position);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -492,7 +492,7 @@ namespace Harness.LanguageService {`
`492`	`492`	`getFormattingEditsAfterKeystroke(fileName: string, position: number, key: string, options: ts.FormatCodeOptions): ts.TextChange[] {`
`493`	`493`	`return unwrapJSONCallResult(this.shim.getFormattingEditsAfterKeystroke(fileName, position, key, JSON.stringify(options)));`
`494`	`494`	`}`
`495`		`- getDocCommentTemplateAtPosition(fileName: string, position: number): ts.TextInsertion {`
	`495`	`+ getDocCommentTemplateAtPosition(fileName: string, position: number): ts.TextInsertion \| undefined {`
`496`	`496`	`return unwrapJSONCallResult(this.shim.getDocCommentTemplateAtPosition(fileName, position));`
`497`	`497`	`}`
`498`	`498`	`isValidBraceCompletionAtPosition(fileName: string, position: number, openingBrace: number): boolean {`
Original file line number	Diff line number	Diff line change
`@@ -1791,7 +1791,7 @@ namespace ts {`
`1791`	`1791`	`}`
`1792`	`1792`	`}`
`1793`	`1793`
`1794`		`- function getDocCommentTemplateAtPosition(fileName: string, position: number): TextInsertion {`
	`1794`	`+ function getDocCommentTemplateAtPosition(fileName: string, position: number): TextInsertion \| undefined {`
`1795`	`1795`	`return JsDoc.getDocCommentTemplateAtPosition(getNewLineOrDefaultFromHost(host), syntaxTreeCache.getCurrentSourceFile(fileName), position);`
`1796`	`1796`	`}`
`1797`	`1797`