Unknown properties are assignable to Object unions

sandersn · sandersn · commit adefdc79538d · 2017-04-18T14:56:11.000-07:00
For the last week or so they have been treated as excess properties when
assigning to a union type containing Object, but not when assigning directly
to Object type.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -8708,7 +8708,7 @@ namespace ts {
                 if (maybeTypeOfKind(target, TypeFlags.Object) && !(getObjectFlags(target) & ObjectFlags.ObjectLiteralPatternWithComputedProperties)) {
                     const isComparingJsxAttributes = !!(source.flags & TypeFlags.JsxAttributes);
                     if ((relation === assignableRelation || relation === comparableRelation) &&
-                        (target === globalObjectType || (!isComparingJsxAttributes && isEmptyObjectType(target)))) {
+                        (isTypeSubsetOf(globalObjectType, target) || (!isComparingJsxAttributes && isEmptyObjectType(target)))) {
                         return false;
                     }
                     for (const prop of getPropertiesOfObjectType(source)) {

Original file line number	Diff line number	Diff line change
`@@ -8708,7 +8708,7 @@ namespace ts {`
`8708`	`8708`	`if (maybeTypeOfKind(target, TypeFlags.Object) && !(getObjectFlags(target) & ObjectFlags.ObjectLiteralPatternWithComputedProperties)) {`
`8709`	`8709`	`const isComparingJsxAttributes = !!(source.flags & TypeFlags.JsxAttributes);`
`8710`	`8710`	`if ((relation === assignableRelation \|\| relation === comparableRelation) &&`
`8711`		`- (target === globalObjectType \|\| (!isComparingJsxAttributes && isEmptyObjectType(target)))) {`
	`8711`	`+ (isTypeSubsetOf(globalObjectType, target) \|\| (!isComparingJsxAttributes && isEmptyObjectType(target)))) {`
`8712`	`8712`	`return false;`
`8713`	`8713`	`}`
`8714`	`8714`	`for (const prop of getPropertiesOfObjectType(source)) {`