addMethodDeclaration codefix creates a generator function when target is child of a YieldExpression, resolves microsoft#24728

krk · krk · commit acbda14450ca · 2018-06-07T20:59:06.000+03:00
diff --git a/src/services/codefixes/helpers.ts b/src/services/codefixes/helpers.ts
@@ -111,16 +111,18 @@ namespace ts.codefix {
     }
 
     export function createMethodFromCallExpression(
-        { typeArguments, arguments: args }: CallExpression,
+        { typeArguments, arguments: args, parent: parent }: CallExpression,
         methodName: string,
         inJs: boolean,
         makeStatic: boolean,
         preferences: UserPreferences,
     ): MethodDeclaration {
+        const asterisk = parent.kind === SyntaxKind.YieldExpression ? createToken(SyntaxKind.AsteriskToken) : undefined;
+
         return createMethod(
             /*decorators*/ undefined,
             /*modifiers*/ makeStatic ? [createToken(SyntaxKind.StaticKeyword)] : undefined,
-            /*asteriskToken*/ undefined,
+            /*asteriskToken*/ asterisk,
             methodName,
             /*questionToken*/ undefined,
             /*typeParameters*/ inJs ? undefined : map(typeArguments, (_, i) =>
diff --git a/tests/cases/fourslash/codeFixAddMissingMember_generator_function.ts b/tests/cases/fourslash/codeFixAddMissingMember_generator_function.ts
@@ -0,0 +1,21 @@
+/// <reference path='fourslash.ts' />
+
+////class C {
+////    *method() {
+////        yield* this.y();
+////    }
+////}
+
+verify.codeFixAll({
+    fixId: "addMissingMember",
+    fixAllDescription: "Add all missing members",
+    newFileContent:
+        `class C {
+    *method() {
+        yield* this.y();
+    }
+    *y(): any {
+        throw new Error("Method not implemented.");
+    }
+}`,
+});
diff --git a/tests/cases/fourslash/codeFixAddMissingMember_non_generator_function.ts b/tests/cases/fourslash/codeFixAddMissingMember_non_generator_function.ts
@@ -0,0 +1,21 @@
+/// <reference path='fourslash.ts' />
+
+////class C {
+////    method() {
+////        yield* this.y();
+////    }
+////}
+
+verify.codeFixAll({
+    fixId: "addMissingMember",
+    fixAllDescription: "Add all missing members",
+    newFileContent:
+        `class C {
+    method() {
+        yield* this.y();
+    }
+    y(): any {
+        throw new Error("Method not implemented.");
+    }
+}`,
+});
