Fix linting errors

aozgaa · aozgaa · commit aa6ecd4154fb · 2016-11-01T15:39:01.000-07:00
diff --git a/src/services/codefixes/fixClassDoesntImplementInheritedAbstractMember.ts b/src/services/codefixes/fixClassDoesntImplementInheritedAbstractMember.ts
@@ -11,11 +11,10 @@ namespace ts.codefix {
             if (token.kind === SyntaxKind.Identifier &&  isClassLike(token.parent)) {
                 const classDeclaration = <ClassDeclaration>token.parent;
                 const startPos = classDeclaration.members.pos;
-                // TODO: (arozga) actually get abstract members
                 const abstractClassMembers = ts.map(getNamedAbstractClassMembers(classDeclaration), member => member.name.getText());
                 const trackingAddedMembers: string[] = [];
                 const extendsClause = ts.getClassExtendsHeritageClauseElement(classDeclaration);
-                let textChanges = getCodeFixChanges(extendsClause, abstractClassMembers, startPos, checker, /*reference*/ false, trackingAddedMembers, context.newLineCharacter);
+                const textChanges = getCodeFixChanges(extendsClause, abstractClassMembers, startPos, checker, /*reference*/ false, trackingAddedMembers, context.newLineCharacter);
 
                 if (textChanges.length > 0) {
                     return [{
diff --git a/src/services/codefixes/fixClassIncorrectlyImplementsInterface.ts b/src/services/codefixes/fixClassIncorrectlyImplementsInterface.ts
@@ -18,7 +18,7 @@ namespace ts.codefix {
                 let textChanges: TextChange[] = undefined;
 
                 for (let i = 0; interfaceClauses && i < interfaceClauses.length; i++) {
-                    let newChanges = getCodeFixChanges(interfaceClauses[i], classMembers, startPos, checker, /*reference*/ false, trackingAddedMembers, context.newLineCharacter);
+                    const newChanges = getCodeFixChanges(interfaceClauses[i], classMembers, startPos, checker, /*reference*/ false, trackingAddedMembers, context.newLineCharacter);
                     textChanges = textChanges ? textChanges.concat(newChanges) : newChanges;
                 }
 
diff --git a/src/services/codefixes/fixExtendsInterfaceBecomesImplements.ts b/src/services/codefixes/fixExtendsInterfaceBecomesImplements.ts
@@ -13,7 +13,7 @@ namespace ts.codefix {
 
             const extendsNode = (token.parent.parent as HeritageClause).getChildren()[0];
 
-            let result = [{
+            const result = [{
                 description: getLocaleSpecificMessage(Diagnostics.Change_extends_to_implements),
                 changes: [{
                     fileName: sourceFile.fileName,
diff --git a/src/services/codefixes/fixRemoveAbstractModifierInNonAbstractClass.ts b/src/services/codefixes/fixRemoveAbstractModifierInNonAbstractClass.ts
@@ -13,13 +13,13 @@ namespace ts.codefix {
             const classDeclaration = <ClassDeclaration>propertyDeclaration.parent;
             const classKeywordStart = classDeclaration.getChildren()[0].getStart();
 
-            let codeFix: CodeAction[] = [
+            return [
                 {
                     description: `Remove abstract modifier from ${propertyDeclaration.name.getText()}.`,
                     changes: [{
                         fileName: sourceFile.fileName,
                         textChanges: [{
-                            span: {start: start, length: context.span.length + /*space*/ 1},
+                            span: { start: start, length: context.span.length + /*space*/ 1 },
                             newText: ""
                         }]
                     }]
@@ -35,8 +35,6 @@ namespace ts.codefix {
                     }]
                 }
             ];
-
-            return codeFix;
         }
     });
 }
diff --git a/src/services/utilities.ts b/src/services/utilities.ts
@@ -1368,8 +1368,8 @@ namespace ts {
         }
 
         const missingMembers = getMissingInterfaceMembers(<InterfaceDeclaration>type.symbol.declarations[0], existingMembers, checker);
-        
-        for (let member of missingMembers) {
+
+        for (const member of missingMembers) {
             if (member.kind === SyntaxKind.PropertySignature) {
                 const interfaceProperty = <PropertySignature>member;
                 if (trackingAddedMembers.indexOf(interfaceProperty.name.getText()) === -1) {
@@ -1422,7 +1422,7 @@ namespace ts {
     }
 
     function getMissingInterfaceMembers(declaration: InterfaceDeclaration, existingMembers: string[], checker: TypeChecker): TypeElement[] {
-        let interfaceMembers = getInterfaceMembers(declaration, checker);
+        const interfaceMembers = getInterfaceMembers(declaration, checker);
 
         return ts.filter(interfaceMembers, member => !member.name || existingMembers.indexOf(member.name.getText()) === -1);
 

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ namespace ts.codefix {`
`18`	`18`	`let textChanges: TextChange[] = undefined;`
`19`	`19`
`20`	`20`	`for (let i = 0; interfaceClauses && i < interfaceClauses.length; i++) {`
`21`		`- let newChanges = getCodeFixChanges(interfaceClauses[i], classMembers, startPos, checker, /reference/ false, trackingAddedMembers, context.newLineCharacter);`
	`21`	`+ const newChanges = getCodeFixChanges(interfaceClauses[i], classMembers, startPos, checker, /reference/ false, trackingAddedMembers, context.newLineCharacter);`
`22`	`22`	`textChanges = textChanges ? textChanges.concat(newChanges) : newChanges;`
`23`	`23`	`}`
`24`	`24`
Original file line number	Diff line number	Diff line change
`@@ -13,13 +13,13 @@ namespace ts.codefix {`
`13`	`13`	`const classDeclaration = <ClassDeclaration>propertyDeclaration.parent;`
`14`	`14`	`const classKeywordStart = classDeclaration.getChildren()[0].getStart();`
`15`	`15`
`16`		`- let codeFix: CodeAction[] = [`
	`16`	`+ return [`
`17`	`17`	`{`
`18`	`18`	description: `Remove abstract modifier from ${propertyDeclaration.name.getText()}.`,
`19`	`19`	`changes: [{`
`20`	`20`	`fileName: sourceFile.fileName,`
`21`	`21`	`textChanges: [{`
`22`		`- span: {start: start, length: context.span.length + /space/ 1},`
	`22`	`+ span: { start: start, length: context.span.length + /space/ 1 },`
`23`	`23`	`newText: ""`
`24`	`24`	`}]`
`25`	`25`	`}]`
`@@ -35,8 +35,6 @@ namespace ts.codefix {`
`35`	`35`	`}]`
`36`	`36`	`}`
`37`	`37`	`];`
`38`		`-`
`39`		`- return codeFix;`
`40`	`38`	`}`
`41`	`39`	`});`
`42`	`40`	`}`