Fix smart select on last blank line of file (microsoft#32544)

andrewbranch · web-flow · commit aa12ec440c9f · 2019-07-25T09:47:57.000-07:00
* Fix SmartSelection on last blank line of file

* Add baseline
diff --git a/src/services/smartSelection.ts b/src/services/smartSelection.ts
@@ -64,6 +64,13 @@ namespace ts.SmartSelectionRange {
                     parentNode = node;
                     break;
                 }
+
+                // If we made it to the end of the for loop, we’re done.
+                // In practice, I’ve only seen this happen at the very end
+                // of a SourceFile.
+                if (i === children.length - 1) {
+                    break outer;
+                }
             }
         }
 
diff --git a/tests/baselines/reference/smartSelection_lastBlankLine.baseline b/tests/baselines/reference/smartSelection_lastBlankLine.baseline
@@ -0,0 +1,5 @@
+class C {}
+/**/
+
+
+class C {}↲
diff --git a/tests/cases/fourslash/smartSelection_lastBlankLine.ts b/tests/cases/fourslash/smartSelection_lastBlankLine.ts
@@ -0,0 +1,5 @@
+/// <reference path="fourslash.ts" />
+////class C {}
+/////**/
+
+verify.baselineSmartSelection();

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,13 @@ namespace ts.SmartSelectionRange {`
`64`	`64`	`parentNode = node;`
`65`	`65`	`break;`
`66`	`66`	`}`
	`67`	`+`
	`68`	`+ // If we made it to the end of the for loop, we’re done.`
	`69`	`+ // In practice, I’ve only seen this happen at the very end`
	`70`	`+ // of a SourceFile.`
	`71`	`+ if (i === children.length - 1) {`
	`72`	`+ break outer;`
	`73`	`+ }`
`67`	`74`	`}`
`68`	`75`	`}`
`69`	`76`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +class C {}
 +/**/
++
++
 +class C {}↲