allow to replace content of script info with empty text (microsoft#11075)

vladima · web-flow · commit a991673f1a14 · 2016-09-22T17:29:18.000-07:00
diff --git a/src/harness/unittests/tsserverProjectSystem.ts b/src/harness/unittests/tsserverProjectSystem.ts
@@ -2035,4 +2035,33 @@ namespace ts.projectSystem {
             checkProjectActualFiles(projectService.configuredProjects[0], [f1.path, t2.path]);
         });
     });
+
+    describe("Open-file", () => {
+        it("can be reloaded with empty content", () => {
+            const f = {
+                path: "/a/b/app.ts",
+                content: "let x = 1"
+            };
+            const projectFileName = "externalProject";
+            const host = createServerHost([f]);
+            const projectService = createProjectService(host);
+            // create a project 
+            projectService.openExternalProject({ projectFileName, rootFiles: [toExternalFile(f.path)], options: {} });
+            projectService.checkNumberOfProjects({ externalProjects: 1 });
+
+            const p = projectService.externalProjects[0];
+            // force to load the content of the file
+            p.updateGraph();
+
+            const scriptInfo = p.getScriptInfo(f.path);
+            checkSnapLength(scriptInfo.snap(), f.content.length);
+
+            // open project and replace its content with empty string
+            projectService.openClientFile(f.path, "");
+            checkSnapLength(scriptInfo.snap(), 0);
+        });
+        function checkSnapLength(snap: server.LineIndexSnapshot, expectedLength: number) {
+            assert.equal(snap.getLength(), expectedLength, "Incorrect snapshot size");
+        }
+    });
 }
diff --git a/src/server/editorServices.ts b/src/server/editorServices.ts
@@ -990,7 +990,7 @@ namespace ts.server {
                 }
             }
             if (info) {
-                if (fileContent) {
+                if (fileContent !== undefined) {
                     info.reload(fileContent);
                 }
                 if (openedByClient) {

Original file line number	Diff line number	Diff line change
`@@ -990,7 +990,7 @@ namespace ts.server {`
`990`	`990`	`}`
`991`	`991`	`}`
`992`	`992`	`if (info) {`
`993`		`- if (fileContent) {`
	`993`	`+ if (fileContent !== undefined) {`
`994`	`994`	`info.reload(fileContent);`
`995`	`995`	`}`
`996`	`996`	`if (openedByClient) {`