Try to pick a good signature, if no signature matches

mhegazy · mhegazy · commit a8a1fa27d854 · 2014-10-08T15:47:30.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -4508,8 +4508,23 @@ module ts {
             }
             else {
                 error(node, Diagnostics.Supplied_parameters_do_not_match_any_signature_of_call_target);
-                return resolveErrorCall(node);
             }
+
+            // No signature was applicable. We have already reported the errors for the invalid signature.
+            // If this is a type resolution session, e.g. Language Service, try to get better information that anySignature.
+            // Pick the first candidate that matches the arity. This way we can get a contextual type for cases like:
+            //  declare function f(a: { xa: number; xb: number; });
+            //  f({ |
+            if (!fullTypeCheck) {
+                if (candidates.length) {
+                    for (var i = 0; i < candidates.length; i++) {
+                        if (signatureHasCorrectArity(node, candidates[i])) {
+                            return candidates[i];
+                        }
+                    }
+                }
+            }
+
             return resolveErrorCall(node);
 
             // The candidate list orders groups in reverse, but within a group signatures are kept in declaration order
diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -1204,7 +1204,8 @@ module ts {
         }
 
         public static toString(parts: SymbolDisplayPart[]) {
-            return parts.map(p => p.text).join("");
+            var result = map(parts, p => p.text);
+            return result ? result.join("") : "";
         }
     }
 
diff --git a/tests/cases/fourslash/completionListInObjectLiteralThatIsParameterOfFunctionCall.ts b/tests/cases/fourslash/completionListInObjectLiteralThatIsParameterOfFunctionCall.ts
@@ -0,0 +1,11 @@
+/// <reference path='fourslash.ts'/>
+
+////function f(a: { xa: number; xb: number; }) { }
+////var xc;
+////f({
+////    /**/
+
+goTo.marker()
+verify.memberListContains('xa');
+verify.memberListContains('xb');
+verify.memberListCount(2);

Original file line number	Diff line number	Diff line change
`@@ -1204,7 +1204,8 @@ module ts {`
`1204`	`1204`	`}`
`1205`	`1205`
`1206`	`1206`	`public static toString(parts: SymbolDisplayPart[]) {`
`1207`		`- return parts.map(p => p.text).join("");`
	`1207`	`+ var result = map(parts, p => p.text);`
	`1208`	`+ return result ? result.join("") : "";`
`1208`	`1209`	`}`
`1209`	`1210`	`}`
`1210`	`1211`