Test:type predicate uses correct index to report errors

sandersn · sandersn · commit a59f77ffb41e · 2017-08-09T15:45:28.000-07:00
diff --git a/tests/baselines/reference/thisTypeInTypePredicate.js b/tests/baselines/reference/thisTypeInTypePredicate.js
@@ -0,0 +1,7 @@
+//// [thisTypeInTypePredicate.ts]
+declare function filter<S>(f: (this: void, x: any) => x is S): S[];
+const numbers = filter<number>((x): x is number => 'number' == typeof x)
+
+
+//// [thisTypeInTypePredicate.js]
+var numbers = filter(function (x) { return 'number' == typeof x; });
diff --git a/tests/baselines/reference/thisTypeInTypePredicate.symbols b/tests/baselines/reference/thisTypeInTypePredicate.symbols
@@ -0,0 +1,18 @@
+=== tests/cases/conformance/types/thisType/thisTypeInTypePredicate.ts ===
+declare function filter<S>(f: (this: void, x: any) => x is S): S[];
+>filter : Symbol(filter, Decl(thisTypeInTypePredicate.ts, 0, 0))
+>S : Symbol(S, Decl(thisTypeInTypePredicate.ts, 0, 24))
+>f : Symbol(f, Decl(thisTypeInTypePredicate.ts, 0, 27))
+>this : Symbol(this, Decl(thisTypeInTypePredicate.ts, 0, 31))
+>x : Symbol(x, Decl(thisTypeInTypePredicate.ts, 0, 42))
+>x : Symbol(x, Decl(thisTypeInTypePredicate.ts, 0, 42))
+>S : Symbol(S, Decl(thisTypeInTypePredicate.ts, 0, 24))
+>S : Symbol(S, Decl(thisTypeInTypePredicate.ts, 0, 24))
+
+const numbers = filter<number>((x): x is number => 'number' == typeof x)
+>numbers : Symbol(numbers, Decl(thisTypeInTypePredicate.ts, 1, 5))
+>filter : Symbol(filter, Decl(thisTypeInTypePredicate.ts, 0, 0))
+>x : Symbol(x, Decl(thisTypeInTypePredicate.ts, 1, 32))
+>x : Symbol(x, Decl(thisTypeInTypePredicate.ts, 1, 32))
+>x : Symbol(x, Decl(thisTypeInTypePredicate.ts, 1, 32))
+
diff --git a/tests/baselines/reference/thisTypeInTypePredicate.types b/tests/baselines/reference/thisTypeInTypePredicate.types
@@ -0,0 +1,23 @@
+=== tests/cases/conformance/types/thisType/thisTypeInTypePredicate.ts ===
+declare function filter<S>(f: (this: void, x: any) => x is S): S[];
+>filter : <S>(f: (this: void, x: any) => x is S) => S[]
+>S : S
+>f : (this: void, x: any) => x is S
+>this : void
+>x : any
+>x : any
+>S : S
+>S : S
+
+const numbers = filter<number>((x): x is number => 'number' == typeof x)
+>numbers : number[]
+>filter<number>((x): x is number => 'number' == typeof x) : number[]
+>filter : <S>(f: (this: void, x: any) => x is S) => S[]
+>(x): x is number => 'number' == typeof x : (this: void, x: any) => x is number
+>x : any
+>x : any
+>'number' == typeof x : boolean
+>'number' : "number"
+>typeof x : "string" | "number" | "boolean" | "symbol" | "undefined" | "object" | "function"
+>x : any
+
diff --git a/tests/cases/conformance/types/thisType/thisTypeInTypePredicate.ts b/tests/cases/conformance/types/thisType/thisTypeInTypePredicate.ts
@@ -0,0 +1,2 @@
+declare function filter<S>(f: (this: void, x: any) => x is S): S[];
+const numbers = filter<number>((x): x is number => 'number' == typeof x)

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+declare function filter<S>(f: (this: void, x: any) => x is S): S[];`
	`2`	`+const numbers = filter<number>((x): x is number => 'number' == typeof x)`