Skip to content

Commit a4db4be

Browse files
committed
Merge pull request microsoft#5019 from RyanCavanaugh/fix4731
Issue correct completions in 'as' operator
2 parents e0bf8cc + 141813c commit a4db4be

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

src/services/services.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3662,9 +3662,9 @@ namespace ts {
36623662
return containingNodeKind === SyntaxKind.Parameter;
36633663

36643664
case SyntaxKind.AsKeyword:
3665-
containingNodeKind === SyntaxKind.ImportSpecifier ||
3666-
containingNodeKind === SyntaxKind.ExportSpecifier ||
3667-
containingNodeKind === SyntaxKind.NamespaceImport;
3665+
return containingNodeKind === SyntaxKind.ImportSpecifier ||
3666+
containingNodeKind === SyntaxKind.ExportSpecifier ||
3667+
containingNodeKind === SyntaxKind.NamespaceImport;
36683668

36693669
case SyntaxKind.ClassKeyword:
36703670
case SyntaxKind.EnumKeyword:
@@ -7814,6 +7814,7 @@ namespace ts {
78147814
case SyntaxKind.GreaterThanEqualsToken:
78157815
case SyntaxKind.InstanceOfKeyword:
78167816
case SyntaxKind.InKeyword:
7817+
case SyntaxKind.AsKeyword:
78177818
case SyntaxKind.EqualsEqualsToken:
78187819
case SyntaxKind.ExclamationEqualsToken:
78197820
case SyntaxKind.EqualsEqualsEqualsToken:
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
/// <reference path="fourslash.ts" />
2+
3+
//// type T = number;
4+
//// var x;
5+
//// var y = x as /**/
6+
7+
goTo.marker();
8+
verify.completionListContains('T');

0 commit comments

Comments
 (0)