non-default args

aozgaa · aozgaa · commit a200aa9329bf · 2017-07-05T12:54:42.000-07:00
diff --git a/src/harness/fourslash.ts b/src/harness/fourslash.ts
@@ -1584,7 +1584,7 @@ namespace FourSlash {
             }
         }
 
-        public printCurrentFileState(makeWhitespaceVisible = false, makeCaretVisible = true) {
+        public printCurrentFileState(makeWhitespaceVisible: boolean, makeCaretVisible: boolean) {
             for (const file of this.testData.files) {
                 const active = (this.activeFile === file);
                 Harness.IO.log(`=== Script (${file.fileName}) ${(active ? "(active, cursor at |)" : "")} ===`);
@@ -1769,7 +1769,7 @@ namespace FourSlash {
          * @returns The number of characters added to the file as a result of the edits.
          * May be negative.
          */
-        private applyEdits(fileName: string, edits: ts.TextChange[], isFormattingEdit = false): number {
+        private applyEdits(fileName: string, edits: ts.TextChange[], isFormattingEdit: boolean): number {
             // We get back a set of edits, but langSvc.editScript only accepts one at a time. Use this to keep track
             // of the incremental offset from each edit to the next. We assume these edit ranges don't overlap
 
@@ -2759,7 +2759,7 @@ namespace FourSlash {
             const editInfo = this.languageService.getEditsForRefactor(this.activeFile.fileName, formattingOptions, markerPos, refactorNameToApply, actionName);
 
             for (const edit of editInfo.edits) {
-                this.applyEdits(edit.fileName, edit.textChanges);
+                this.applyEdits(edit.fileName, edit.textChanges, /*isFormattingEdit*/ false);
             }
             const actualContent = this.getFileContent(this.activeFile.fileName);
 
@@ -4002,11 +4002,11 @@ namespace FourSlashInterface {
         }
 
         public printCurrentFileState() {
-            this.state.printCurrentFileState(/*makeWhitespaceVisible*/ true, /*makeCaretVisible*/ true);
+            this.state.printCurrentFileState(/*makeWhitespaceVisible*/ false, /*makeCaretVisible*/ true);
         }
 
         public printCurrentFileStateWithWhitespace() {
-            this.state.printCurrentFileState(/*makeWhitespaceVisible*/ true);
+            this.state.printCurrentFileState(/*makeWhitespaceVisible*/ true, /*makeCaretVisible*/ true);
         }
 
         public printCurrentFileStateWithoutCaret() {

Original file line number	Diff line number	Diff line change
`@@ -1584,7 +1584,7 @@ namespace FourSlash {`
`1584`	`1584`	`}`
`1585`	`1585`	`}`
`1586`	`1586`
`1587`		`- public printCurrentFileState(makeWhitespaceVisible = false, makeCaretVisible = true) {`
	`1587`	`+ public printCurrentFileState(makeWhitespaceVisible: boolean, makeCaretVisible: boolean) {`
`1588`	`1588`	`for (const file of this.testData.files) {`
`1589`	`1589`	`const active = (this.activeFile === file);`
`1590`	`1590`	Harness.IO.log(`=== Script (${file.fileName}) ${(active ? "(active, cursor at \|)" : "")} ===`);
`@@ -1769,7 +1769,7 @@ namespace FourSlash {`
`1769`	`1769`	`* @returns The number of characters added to the file as a result of the edits.`
`1770`	`1770`	`* May be negative.`
`1771`	`1771`	`*/`
`1772`		`- private applyEdits(fileName: string, edits: ts.TextChange[], isFormattingEdit = false): number {`
	`1772`	`+ private applyEdits(fileName: string, edits: ts.TextChange[], isFormattingEdit: boolean): number {`
`1773`	`1773`	`// We get back a set of edits, but langSvc.editScript only accepts one at a time. Use this to keep track`
`1774`	`1774`	`// of the incremental offset from each edit to the next. We assume these edit ranges don't overlap`
`1775`	`1775`
`@@ -2759,7 +2759,7 @@ namespace FourSlash {`
`2759`	`2759`	`const editInfo = this.languageService.getEditsForRefactor(this.activeFile.fileName, formattingOptions, markerPos, refactorNameToApply, actionName);`
`2760`	`2760`
`2761`	`2761`	`for (const edit of editInfo.edits) {`
`2762`		`- this.applyEdits(edit.fileName, edit.textChanges);`
	`2762`	`+ this.applyEdits(edit.fileName, edit.textChanges, /isFormattingEdit/ false);`
`2763`	`2763`	`}`
`2764`	`2764`	`const actualContent = this.getFileContent(this.activeFile.fileName);`
`2765`	`2765`
`@@ -4002,11 +4002,11 @@ namespace FourSlashInterface {`
`4002`	`4002`	`}`
`4003`	`4003`
`4004`	`4004`	`public printCurrentFileState() {`
`4005`		`- this.state.printCurrentFileState(/makeWhitespaceVisible/ true, /makeCaretVisible/ true);`
	`4005`	`+ this.state.printCurrentFileState(/makeWhitespaceVisible/ false, /makeCaretVisible/ true);`
`4006`	`4006`	`}`
`4007`	`4007`
`4008`	`4008`	`public printCurrentFileStateWithWhitespace() {`
`4009`		`- this.state.printCurrentFileState(/makeWhitespaceVisible/ true);`
	`4009`	`+ this.state.printCurrentFileState(/makeWhitespaceVisible/ true, /makeCaretVisible/ true);`
`4010`	`4010`	`}`
`4011`	`4011`
`4012`	`4012`	`public printCurrentFileStateWithoutCaret() {`