Explicitly error when an exclude is provided by a test as it will be unused (microsoft#32014)

weswigham · web-flow · commit a150d55592db · 2019-06-24T15:29:02.000-07:00
diff --git a/src/testRunner/compilerRunner.ts b/src/testRunner/compilerRunner.ts
@@ -143,6 +143,7 @@ class CompilerTest {
         this.tsConfigFiles = [];
         if (testCaseContent.tsConfig) {
             assert.equal(testCaseContent.tsConfig.fileNames.length, 0, `list of files in tsconfig is not currently supported`);
+            assert.equal(testCaseContent.tsConfig.raw.exclude, undefined, `exclude in tsconfig is not currently supported`);
 
             tsConfigOptions = ts.cloneCompilerOptions(testCaseContent.tsConfig.options);
             this.tsConfigFiles.push(this.createHarnessTestFile(testCaseContent.tsConfigFileUnitData!, rootDir, ts.combinePaths(rootDir, tsConfigOptions.configFilePath!)));
diff --git a/tests/baselines/reference/maxNodeModuleJsDepthDefaultsToZero.errors.txt b/tests/baselines/reference/maxNodeModuleJsDepthDefaultsToZero.errors.txt
@@ -8,8 +8,7 @@
             "module": "commonjs",
             "moduleResolution": "node",
             "outDir": "bin"
-        },
-        "exclude": [ "node_modules" ]
+        }
     }
 ==== /index.ts (1 errors) ====
     /// <reference path="/typings/index.d.ts" />
diff --git a/tests/cases/compiler/compositeWithNodeModulesSourceFile.ts b/tests/cases/compiler/compositeWithNodeModulesSourceFile.ts
@@ -1,7 +1,6 @@
 // @filename: /foo/tsconfig.json
 {
-    "compilerOptions": { "composite": true },
-    "exclude": [ "node_modules" ]
+    "compilerOptions": { "composite": true }
 }
 
 // @filename: /foo/node_modules/myModule/index.ts
diff --git a/tests/cases/compiler/maxNodeModuleJsDepthDefaultsToZero.ts b/tests/cases/compiler/maxNodeModuleJsDepthDefaultsToZero.ts
@@ -11,8 +11,7 @@
         "module": "commonjs",
         "moduleResolution": "node",
         "outDir": "bin"
-    },
-    "exclude": [ "node_modules" ]
+    }
 }
 // @filename: /node_modules/shortid/node_modules/z/index.js
 // z will not be found because maxNodeModulesJsDepth: 0

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,6 @@`
`1`	`1`	`// @filename: /foo/tsconfig.json`
`2`	`2`	`{`
`3`		`- "compilerOptions": { "composite": true },`
`4`		`- "exclude": [ "node_modules" ]`
	`3`	`+ "compilerOptions": { "composite": true }`
`5`	`4`	`}`
`6`	`5`
`7`	`6`	`// @filename: /foo/node_modules/myModule/index.ts`