Add tests

Yui T · Yui T · commit a034314a9e92 · 2015-12-21T15:45:58.000-08:00
diff --git a/src/compiler/emitter.ts b/src/compiler/emitter.ts
@@ -3848,7 +3848,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, Promi
                         // We create a synthetic copy of the identifier in order to avoid the rewriting that might
                         // otherwise occur when the identifier is emitted.
                         index = <Identifier | LiteralExpression>createSynthesizedNode(propName.kind);
-                        (<Identifier | LiteralExpression>index).text = (<Identifier | LiteralExpression>propName).text;
+                        (<Identifier | LiteralExpression>index).text = unescapeIdentifier((<Identifier | LiteralExpression>propName).text);
                     }
 
                     return !nameIsComputed && index.kind === SyntaxKind.Identifier
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -238,11 +238,10 @@ namespace ts {
             return identifier.charCodeAt(0) === CharacterCodes._ && identifier.charCodeAt(1) === CharacterCodes._ ? true : false;
         }
     }
-    
+
     // Add an extra underscore to identifiers that start with two underscores to avoid issues with magic names like '__proto__'
-    // TODO(yuisu): comment
     export function escapeIdentifier(identifier: string): string {
-        return prefixWithUnderscoreUnderscore(identifier)? "_" + identifier : identifier;
+        return prefixWithUnderscoreUnderscore(identifier) ? "_" + identifier : identifier;
     }
 
     // Remove extra underscore from escaped identifier

Original file line number	Diff line number	Diff line change
`@@ -3848,7 +3848,7 @@ var __awaiter = (this && this.__awaiter) \|\| function (thisArg, _arguments, Promi`
`3848`	`3848`	`// We create a synthetic copy of the identifier in order to avoid the rewriting that might`
`3849`	`3849`	`// otherwise occur when the identifier is emitted.`
`3850`	`3850`	`index = <Identifier \| LiteralExpression>createSynthesizedNode(propName.kind);`
`3851`		`- (<Identifier \| LiteralExpression>index).text = (<Identifier \| LiteralExpression>propName).text;`
	`3851`	`+ (<Identifier \| LiteralExpression>index).text = unescapeIdentifier((<Identifier \| LiteralExpression>propName).text);`
`3852`	`3852`	`}`
`3853`	`3853`
`3854`	`3854`	`return !nameIsComputed && index.kind === SyntaxKind.Identifier`
Original file line number	Diff line number	Diff line change
`@@ -238,11 +238,10 @@ namespace ts {`
`238`	`238`	`return identifier.charCodeAt(0) === CharacterCodes._ && identifier.charCodeAt(1) === CharacterCodes._ ? true : false;`
`239`	`239`	`}`
`240`	`240`	`}`
`241`		`-`
	`241`	`+`
`242`	`242`	`// Add an extra underscore to identifiers that start with two underscores to avoid issues with magic names like '__proto__'`
`243`		`- // TODO(yuisu): comment`
`244`	`243`	`export function escapeIdentifier(identifier: string): string {`
`245`		`- return prefixWithUnderscoreUnderscore(identifier)? "_" + identifier : identifier;`
	`244`	`+ return prefixWithUnderscoreUnderscore(identifier) ? "_" + identifier : identifier;`
`246`	`245`	`}`
`247`	`246`
`248`	`247`	`// Remove extra underscore from escaped identifier`