microsoft-typescript/no-in-operator

a-tarasyuk · a-tarasyuk · commit 9fcaa19ab034 · 2019-06-20T14:13:46.000+03:00
diff --git a/.eslintrc b/.eslintrc
@@ -59,7 +59,7 @@
         }],
         "microsoft-typescript/no-double-space": "error",
         "microsoft-typescript/boolean-trivia": "error",
-        "microsoft-typescript/no-in-operator": "off",
+        "microsoft-typescript/no-in-operator": "error",
         "microsoft-typescript/debug-assert": "error",
         "microsoft-typescript/no-keywords": "error",
 
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -835,7 +835,7 @@ namespace ts {
             }
         }
         function errorOrSuggestion(isError: boolean, location: Node, message: DiagnosticMessage | DiagnosticMessageChain, arg0?: string | number, arg1?: string | number, arg2?: string | number, arg3?: string | number): void {
-            addErrorOrSuggestion(isError, "message" in message ? createDiagnosticForNode(location, message, arg0, arg1, arg2, arg3) : createDiagnosticForNodeFromMessageChain(location, message));
+            addErrorOrSuggestion(isError, "message" in message ? createDiagnosticForNode(location, message, arg0, arg1, arg2, arg3) : createDiagnosticForNodeFromMessageChain(location, message)); // eslint-disable-line microsoft-typescript/no-in-operator
         }
 
         function createSymbol(flags: SymbolFlags, name: __String, checkFlags?: CheckFlags) {
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -114,7 +114,7 @@ namespace ts {
     // The global Map object. This may not be available, so we must test for it.
     declare const Map: (new <T>() => Map<T>) | undefined;
     // Internet Explorer's Map doesn't support iteration, so don't use it.
-    // tslint:disable-next-line no-in-operator variable-name
+    // eslint-disable-next-line microsoft-typescript/no-in-operator
     export const MapCtr = typeof Map !== "undefined" && "entries" in Map.prototype ? Map : shimMap();
 
     // Keep the class inside a function so it doesn't get compiled if it's not used.
@@ -221,7 +221,7 @@ namespace ts {
             }
 
             has(key: string): boolean {
-                // tslint:disable-next-line:no-in-operator
+                // eslint-disable-next-line microsoft-typescript/no-in-operator
                 return key in this.data;
             }
 
diff --git a/src/compiler/debug.ts b/src/compiler/debug.ts
@@ -66,7 +66,7 @@ namespace ts {
         }
 
         export function assertNever(member: never, message = "Illegal value:", stackCrawlMark?: AnyFunction): never {
-            const detail = typeof member === "object" && "kind" in member && "pos" in member && formatSyntaxKind ? "SyntaxKind: " + formatSyntaxKind((member as Node).kind) : JSON.stringify(member);
+            const detail = typeof member === "object" && hasProperty(member, "kind") && hasProperty(member, "pos") && formatSyntaxKind ? "SyntaxKind: " + formatSyntaxKind((member as Node).kind) : JSON.stringify(member);
             return fail(`${message} ${detail}`, stackCrawlMark || assertNever);
         }
 
diff --git a/src/compiler/factory.ts b/src/compiler/factory.ts
@@ -75,6 +75,7 @@ namespace ts {
         if (typeof value === "number") {
             return createNumericLiteral(value + "");
         }
+        // eslint-disable-next-line microsoft-typescript/no-in-operator
         if (typeof value === "object" && "base10Value" in value) { // PseudoBigInt
             return createBigIntLiteral(pseudoBigIntToString(value) + "n");
         }
diff --git a/src/harness/fourslash.ts b/src/harness/fourslash.ts
@@ -746,15 +746,15 @@ namespace FourSlash {
         private verifyCompletionsWorker(options: FourSlashInterface.VerifyCompletionsOptions): void {
             const actualCompletions = this.getCompletionListAtCaret({ ...options.preferences, triggerCharacter: options.triggerCharacter })!;
             if (!actualCompletions) {
-                if ("exact" in options && options.exact === undefined) return;
+                if (ts.hasProperty(options, "exact") && options.exact === undefined) return;
                 this.raiseError(`No completions at position '${this.currentCaretPosition}'.`);
             }
 
             if (actualCompletions.isNewIdentifierLocation !== (options.isNewIdentifierLocation || false)) {
                 this.raiseError(`Expected 'isNewIdentifierLocation' to be ${options.isNewIdentifierLocation || false}, got ${actualCompletions.isNewIdentifierLocation}`);
             }
 
-            if ("isGlobalCompletion" in options && actualCompletions.isGlobalCompletion !== options.isGlobalCompletion) {
+            if (ts.hasProperty(options, "isGlobalCompletion") && actualCompletions.isGlobalCompletion !== options.isGlobalCompletion) {
                 this.raiseError(`Expected 'isGlobalCompletion to be ${options.isGlobalCompletion}, got ${actualCompletions.isGlobalCompletion}`);
             }
 
@@ -772,8 +772,8 @@ namespace FourSlash {
                 }
             }
 
-            if ("exact" in options) {
-                ts.Debug.assert(!("includes" in options) && !("excludes" in options));
+            if (ts.hasProperty(options, "exact")) {
+                ts.Debug.assert(!ts.hasProperty(options, "includes") && !ts.hasProperty(options, "excludes"));
                 if (options.exact === undefined) throw this.raiseError("Expected no completions");
                 this.verifyCompletionsAreExactly(actualCompletions.entries, toArray(options.exact), options.marker);
             }
@@ -1192,7 +1192,7 @@ Actual: ${stringify(fullActual)}`);
                 const sort = (locations: ReadonlyArray<ts.RenameLocation> | undefined) =>
                     locations && ts.sort(locations, (r1, r2) => ts.compareStringsCaseSensitive(r1.fileName, r2.fileName) || r1.textSpan.start - r2.textSpan.start);
                 assert.deepEqual(sort(references), sort(ranges.map((rangeOrOptions): ts.RenameLocation => {
-                    const { range, ...prefixSuffixText } = "range" in rangeOrOptions ? rangeOrOptions : { range: rangeOrOptions };
+                    const { range, ...prefixSuffixText } = "range" in rangeOrOptions ? rangeOrOptions : { range: rangeOrOptions }; // eslint-disable-line microsoft-typescript/no-in-operator
                     const { contextRangeIndex } = (range.marker && range.marker.data || {}) as { contextRangeIndex?: number; };
                     return {
                         fileName: range.fileName,
@@ -3129,7 +3129,7 @@ Actual: ${stringify(fullActual)}`);
             return this.getApplicableRefactorsWorker(this.getSelection(), this.activeFile.fileName);
         }
         private getApplicableRefactors(rangeOrMarker: Range | Marker, preferences = ts.emptyOptions): ReadonlyArray<ts.ApplicableRefactorInfo> {
-            return this.getApplicableRefactorsWorker("position" in rangeOrMarker ? rangeOrMarker.position : rangeOrMarker, rangeOrMarker.fileName, preferences);
+            return this.getApplicableRefactorsWorker("position" in rangeOrMarker ? rangeOrMarker.position : rangeOrMarker, rangeOrMarker.fileName, preferences); // eslint-disable-line microsoft-typescript/no-in-operator
         }
         private getApplicableRefactorsWorker(positionOrRange: number | ts.TextRange, fileName: string, preferences = ts.emptyOptions): ReadonlyArray<ts.ApplicableRefactorInfo> {
             return this.languageService.getApplicableRefactors(fileName, positionOrRange, preferences) || ts.emptyArray;
diff --git a/src/server/project.ts b/src/server/project.ts
@@ -1190,6 +1190,7 @@ namespace ts.server {
                 const pluginModule = pluginModuleFactory({ typescript: ts });
                 const newLS = pluginModule.create(info);
                 for (const k of Object.keys(this.languageService)) {
+                    // eslint-disable-next-line microsoft-typescript/no-in-operator
                     if (!(k in newLS)) {
                         this.projectService.logger.info(`Plugin activation warning: Missing proxied method ${k} in created LS. Patching.`);
                         (newLS as any)[k] = (this.languageService as any)[k];
diff --git a/src/services/codefixes/convertToAsyncFunction.ts b/src/services/codefixes/convertToAsyncFunction.ts
@@ -607,6 +607,7 @@ namespace ts.codefix {
         }
 
         // return undefined argName when arg is null or undefined
+        // eslint-disable-next-line microsoft-typescript/no-in-operator
         if (!name || "identifier" in name && name.identifier.text === "undefined") {
             return undefined;
         }
diff --git a/src/services/findAllReferences.ts b/src/services/findAllReferences.ts
@@ -1440,7 +1440,7 @@ namespace ts.FindAllReferences.Core {
     }
 
     function addReference(referenceLocation: Node, relatedSymbol: Symbol | RelatedSymbol, state: State): void {
-        const { kind, symbol } = "kind" in relatedSymbol ? relatedSymbol : { kind: undefined, symbol: relatedSymbol };
+        const { kind, symbol } = "kind" in relatedSymbol ? relatedSymbol : { kind: undefined, symbol: relatedSymbol }; // eslint-disable-line microsoft-typescript/no-in-operator
         const addRef = state.referenceAdder(symbol);
         if (state.options.implementations) {
             addImplementationReferences(referenceLocation, addRef, state);
diff --git a/src/services/shims.ts b/src/services/shims.ts
@@ -18,7 +18,7 @@ let debugObjectHost: { CollectGarbage(): void } = (function (this: any) { return
 
 // We need to use 'null' to interface with the managed side.
 /* tslint:disable:no-null-keyword */
-/* tslint:disable:no-in-operator */
+/* eslint-disable microsoft-typescript/no-in-operator */
 
 /* @internal */
 namespace ts {
@@ -1271,7 +1271,7 @@ namespace ts {
     }
 }
 
-/* tslint:enable:no-in-operator */
+/* eslint-enable microsoft-typescript/no-in-operator */
 /* tslint:enable:no-null */
 
 
diff --git a/src/testRunner/parallel/host.ts b/src/testRunner/parallel/host.ts
@@ -51,7 +51,7 @@ namespace Harness.Parallel.Host {
             constructor(info: ErrorInfo | TestInfo) {
                 super(info.name[info.name.length - 1]);
                 this.info = info;
-                this.state = "error" in info ? "failed" : "passed";
+                this.state = "error" in info ? "failed" : "passed"; // eslint-disable-line microsoft-typescript/no-in-operator
                 this.pending = false;
             }
         }
@@ -518,7 +518,7 @@ namespace Harness.Parallel.Host {
                 function replayTest(runner: Mocha.Runner, test: RemoteTest) {
                     runner.emit("test", test);
                     if (test.isFailed()) {
-                        runner.emit("fail", test, "error" in test.info ? rebuildError(test.info) : new Error("Unknown error"));
+                        runner.emit("fail", test, "error" in test.info ? rebuildError(test.info) : new Error("Unknown error")); // eslint-disable-line microsoft-typescript/no-in-operator
                     }
                     else {
                         runner.emit("pass", test);
diff --git a/src/testRunner/unittests/services/extract/helpers.ts b/src/testRunner/unittests/services/extract/helpers.ts
@@ -43,7 +43,7 @@ namespace ts {
                 text += source.substring(lastPos, pos);
                 activeRanges[activeRanges.length - 1].end = text.length;
                 const range = activeRanges.pop()!;
-                if (range.name in ranges) {
+                if (hasProperty(ranges, range.name)) {
                     throw new Error(`Duplicate name of range ${range.name}`);
                 }
                 ranges.set(range.name, range);
@@ -173,4 +173,4 @@ namespace ts {
             assert.isUndefined(find(infos, info => info.description === description.message));
         });
     }
-}
+}
diff --git a/src/testRunner/unittests/tsserver/helpers.ts b/src/testRunner/unittests/tsserver/helpers.ts
@@ -662,7 +662,7 @@ namespace ts.projectSystem {
     export function openFilesForSession(files: ReadonlyArray<File | { readonly file: File | string, readonly projectRootPath: string }>, session: server.Session): void {
         for (const file of files) {
             session.executeCommand(makeSessionRequest<protocol.OpenRequestArgs>(CommandNames.Open,
-                "projectRootPath" in file ? { file: typeof file.file === "string" ? file.file : file.file.path, projectRootPath: file.projectRootPath } : { file: file.path }));
+                "projectRootPath" in file ? { file: typeof file.file === "string" ? file.file : file.file.path, projectRootPath: file.projectRootPath } : { file: file.path })); // eslint-disable-line microsoft-typescript/no-in-operator
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -835,7 +835,7 @@ namespace ts {`
`835`	`835`	`}`
`836`	`836`	`}`
`837`	`837`	`function errorOrSuggestion(isError: boolean, location: Node, message: DiagnosticMessage \| DiagnosticMessageChain, arg0?: string \| number, arg1?: string \| number, arg2?: string \| number, arg3?: string \| number): void {`
`838`		`- addErrorOrSuggestion(isError, "message" in message ? createDiagnosticForNode(location, message, arg0, arg1, arg2, arg3) : createDiagnosticForNodeFromMessageChain(location, message));`
	`838`	`+ addErrorOrSuggestion(isError, "message" in message ? createDiagnosticForNode(location, message, arg0, arg1, arg2, arg3) : createDiagnosticForNodeFromMessageChain(location, message)); // eslint-disable-line microsoft-typescript/no-in-operator`
`839`	`839`	`}`
`840`	`840`
`841`	`841`	`function createSymbol(flags: SymbolFlags, name: __String, checkFlags?: CheckFlags) {`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ namespace ts {`
`114`	`114`	`// The global Map object. This may not be available, so we must test for it.`
`115`	`115`	`declare const Map: (new <T>() => Map<T>) \| undefined;`
`116`	`116`	`// Internet Explorer's Map doesn't support iteration, so don't use it.`
`117`		`- // tslint:disable-next-line no-in-operator variable-name`
	`117`	`+ // eslint-disable-next-line microsoft-typescript/no-in-operator`
`118`	`118`	`export const MapCtr = typeof Map !== "undefined" && "entries" in Map.prototype ? Map : shimMap();`
`119`	`119`
`120`	`120`	`// Keep the class inside a function so it doesn't get compiled if it's not used.`
`@@ -221,7 +221,7 @@ namespace ts {`
`221`	`221`	`}`
`222`	`222`
`223`	`223`	`has(key: string): boolean {`
`224`		`- // tslint:disable-next-line:no-in-operator`
	`224`	`+ // eslint-disable-next-line microsoft-typescript/no-in-operator`
`225`	`225`	`return key in this.data;`
`226`	`226`	`}`
`227`	`227`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ namespace ts {`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`export function assertNever(member: never, message = "Illegal value:", stackCrawlMark?: AnyFunction): never {`
`69`		`- const detail = typeof member === "object" && "kind" in member && "pos" in member && formatSyntaxKind ? "SyntaxKind: " + formatSyntaxKind((member as Node).kind) : JSON.stringify(member);`
	`69`	`+ const detail = typeof member === "object" && hasProperty(member, "kind") && hasProperty(member, "pos") && formatSyntaxKind ? "SyntaxKind: " + formatSyntaxKind((member as Node).kind) : JSON.stringify(member);`
`70`	`70`	return fail(`${message} ${detail}`, stackCrawlMark \|\| assertNever);
`71`	`71`	`}`
`72`	`72`
Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,7 @@ namespace ts {`
`75`	`75`	`if (typeof value === "number") {`
`76`	`76`	`return createNumericLiteral(value + "");`
`77`	`77`	`}`
	`78`	`+ // eslint-disable-next-line microsoft-typescript/no-in-operator`
`78`	`79`	`if (typeof value === "object" && "base10Value" in value) { // PseudoBigInt`
`79`	`80`	`return createBigIntLiteral(pseudoBigIntToString(value) + "n");`
`80`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -746,15 +746,15 @@ namespace FourSlash {`
`746`	`746`	`private verifyCompletionsWorker(options: FourSlashInterface.VerifyCompletionsOptions): void {`
`747`	`747`	`const actualCompletions = this.getCompletionListAtCaret({ ...options.preferences, triggerCharacter: options.triggerCharacter })!;`
`748`	`748`	`if (!actualCompletions) {`
`749`		`- if ("exact" in options && options.exact === undefined) return;`
	`749`	`+ if (ts.hasProperty(options, "exact") && options.exact === undefined) return;`
`750`	`750`	this.raiseError(`No completions at position '${this.currentCaretPosition}'.`);
`751`	`751`	`}`
`752`	`752`
`753`	`753`	`if (actualCompletions.isNewIdentifierLocation !== (options.isNewIdentifierLocation \|\| false)) {`
`754`	`754`	this.raiseError(`Expected 'isNewIdentifierLocation' to be ${options.isNewIdentifierLocation \|\| false}, got ${actualCompletions.isNewIdentifierLocation}`);
`755`	`755`	`}`
`756`	`756`
`757`		`- if ("isGlobalCompletion" in options && actualCompletions.isGlobalCompletion !== options.isGlobalCompletion) {`
	`757`	`+ if (ts.hasProperty(options, "isGlobalCompletion") && actualCompletions.isGlobalCompletion !== options.isGlobalCompletion) {`
`758`	`758`	this.raiseError(`Expected 'isGlobalCompletion to be ${options.isGlobalCompletion}, got ${actualCompletions.isGlobalCompletion}`);
`759`	`759`	`}`
`760`	`760`
`@@ -772,8 +772,8 @@ namespace FourSlash {`
`772`	`772`	`}`
`773`	`773`	`}`
`774`	`774`
`775`		`- if ("exact" in options) {`
`776`		`- ts.Debug.assert(!("includes" in options) && !("excludes" in options));`
	`775`	`+ if (ts.hasProperty(options, "exact")) {`
	`776`	`+ ts.Debug.assert(!ts.hasProperty(options, "includes") && !ts.hasProperty(options, "excludes"));`
`777`	`777`	`if (options.exact === undefined) throw this.raiseError("Expected no completions");`
`778`	`778`	`this.verifyCompletionsAreExactly(actualCompletions.entries, toArray(options.exact), options.marker);`
`779`	`779`	`}`
@@ -1192,7 +1192,7 @@ Actual: ${stringify(fullActual)}`);
`1192`	`1192`	`const sort = (locations: ReadonlyArray<ts.RenameLocation> \| undefined) =>`
`1193`	`1193`	`locations && ts.sort(locations, (r1, r2) => ts.compareStringsCaseSensitive(r1.fileName, r2.fileName) \|\| r1.textSpan.start - r2.textSpan.start);`
`1194`	`1194`	`assert.deepEqual(sort(references), sort(ranges.map((rangeOrOptions): ts.RenameLocation => {`
`1195`		`- const { range, ...prefixSuffixText } = "range" in rangeOrOptions ? rangeOrOptions : { range: rangeOrOptions };`
	`1195`	`+ const { range, ...prefixSuffixText } = "range" in rangeOrOptions ? rangeOrOptions : { range: rangeOrOptions }; // eslint-disable-line microsoft-typescript/no-in-operator`
`1196`	`1196`	`const { contextRangeIndex } = (range.marker && range.marker.data \|\| {}) as { contextRangeIndex?: number; };`
`1197`	`1197`	`return {`
`1198`	`1198`	`fileName: range.fileName,`
@@ -3129,7 +3129,7 @@ Actual: ${stringify(fullActual)}`);
`3129`	`3129`	`return this.getApplicableRefactorsWorker(this.getSelection(), this.activeFile.fileName);`
`3130`	`3130`	`}`
`3131`	`3131`	`private getApplicableRefactors(rangeOrMarker: Range \| Marker, preferences = ts.emptyOptions): ReadonlyArray<ts.ApplicableRefactorInfo> {`
`3132`		`- return this.getApplicableRefactorsWorker("position" in rangeOrMarker ? rangeOrMarker.position : rangeOrMarker, rangeOrMarker.fileName, preferences);`
	`3132`	`+ return this.getApplicableRefactorsWorker("position" in rangeOrMarker ? rangeOrMarker.position : rangeOrMarker, rangeOrMarker.fileName, preferences); // eslint-disable-line microsoft-typescript/no-in-operator`
`3133`	`3133`	`}`
`3134`	`3134`	`private getApplicableRefactorsWorker(positionOrRange: number \| ts.TextRange, fileName: string, preferences = ts.emptyOptions): ReadonlyArray<ts.ApplicableRefactorInfo> {`
`3135`	`3135`	`return this.languageService.getApplicableRefactors(fileName, positionOrRange, preferences) \|\| ts.emptyArray;`
Original file line number	Diff line number	Diff line change
`@@ -607,6 +607,7 @@ namespace ts.codefix {`
`607`	`607`	`}`
`608`	`608`
`609`	`609`	`// return undefined argName when arg is null or undefined`
	`610`	`+ // eslint-disable-next-line microsoft-typescript/no-in-operator`
`610`	`611`	`if (!name \|\| "identifier" in name && name.identifier.text === "undefined") {`
`611`	`612`	`return undefined;`
`612`	`613`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1440,7 +1440,7 @@ namespace ts.FindAllReferences.Core {`
`1440`	`1440`	`}`
`1441`	`1441`
`1442`	`1442`	`function addReference(referenceLocation: Node, relatedSymbol: Symbol \| RelatedSymbol, state: State): void {`
`1443`		`- const { kind, symbol } = "kind" in relatedSymbol ? relatedSymbol : { kind: undefined, symbol: relatedSymbol };`
	`1443`	`+ const { kind, symbol } = "kind" in relatedSymbol ? relatedSymbol : { kind: undefined, symbol: relatedSymbol }; // eslint-disable-line microsoft-typescript/no-in-operator`
`1444`	`1444`	`const addRef = state.referenceAdder(symbol);`
`1445`	`1445`	`if (state.options.implementations) {`
`1446`	`1446`	`addImplementationReferences(referenceLocation, addRef, state);`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ let debugObjectHost: { CollectGarbage(): void } = (function (this: any) { return`
`18`	`18`
`19`	`19`	`// We need to use 'null' to interface with the managed side.`
`20`	`20`	`/* tslint:disable:no-null-keyword */`
`21`		`-/* tslint:disable:no-in-operator */`
	`21`	`+/* eslint-disable microsoft-typescript/no-in-operator */`
`22`	`22`
`23`	`23`	`/* @internal */`
`24`	`24`	`namespace ts {`
`@@ -1271,7 +1271,7 @@ namespace ts {`
`1271`	`1271`	`}`
`1272`	`1272`	`}`
`1273`	`1273`
`1274`		`-/* tslint:enable:no-in-operator */`
	`1274`	`+/* eslint-enable microsoft-typescript/no-in-operator */`
`1275`	`1275`	`/* tslint:enable:no-null */`
`1276`	`1276`
`1277`	`1277`