Add support for //@check directives

mhegazy · mhegazy · commit 9f0c5ce1418d · 2017-03-06T13:50:27.000-08:00
diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts
@@ -5817,6 +5817,7 @@ namespace ts {
             const typeReferenceDirectives: FileReference[] = [];
             const amdDependencies: { path: string; name: string }[] = [];
             let amdModuleName: string;
+            let hasCheckDirective = false;
 
             // Keep scanning all the leading trivia in the file until we get to something that
             // isn't trivia.  Any single line comment will be analyzed to see if it is a
@@ -5878,13 +5879,17 @@ namespace ts {
                             amdDependencies.push(amdDependency);
                         }
                     }
+
+                    const checkDirectiveRegEx = /^\/\/\s*@check\s*/gim;
+                    hasCheckDirective = hasCheckDirective || !!checkDirectiveRegEx.exec(comment);
                 }
             }
 
             sourceFile.referencedFiles = referencedFiles;
             sourceFile.typeReferenceDirectives = typeReferenceDirectives;
             sourceFile.amdDependencies = amdDependencies;
             sourceFile.moduleName = amdModuleName;
+            sourceFile.hasCheckDirective = hasCheckDirective;
         }
 
         function setExternalModuleIndicator(sourceFile: SourceFile) {
diff --git a/src/compiler/program.ts b/src/compiler/program.ts
@@ -907,7 +907,8 @@ namespace ts {
                 // For JavaScript files, we don't want to report semantic errors.
                 // Instead, we'll report errors for using TypeScript-only constructs from within a
                 // JavaScript file when we get syntactic diagnostics for the file.
-                const checkDiagnostics = !options.checkJsFiles && isSourceFileJavaScript(sourceFile) ? [] : typeChecker.getDiagnostics(sourceFile, cancellationToken);
+                const includeCheckDiagnostics = options.checkJsFiles || sourceFile.hasCheckDirective || !isSourceFileJavaScript(sourceFile);
+                const checkDiagnostics = includeCheckDiagnostics ? typeChecker.getDiagnostics(sourceFile, cancellationToken) : [];
                 const fileProcessingDiagnosticsInFile = fileProcessingDiagnostics.getDiagnostics(sourceFile.fileName);
                 const programDiagnosticsInFile = programDiagnostics.getDiagnostics(sourceFile.fileName);
 
diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -2272,6 +2272,7 @@
         /* @internal */ moduleAugmentations: LiteralExpression[];
         /* @internal */ patternAmbientModules?: PatternAmbientModule[];
         /* @internal */ ambientModuleNames: string[];
+        /* @internal */ hasCheckDirective: boolean;
     }
 
     export interface Bundle extends Node {
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -473,6 +473,7 @@ namespace ts {
         public moduleAugmentations: LiteralExpression[];
         private namedDeclarations: Map<Declaration[]>;
         public ambientModuleNames: string[];
+        public hasCheckDirective: boolean;
 
         constructor(kind: SyntaxKind, pos: number, end: number) {
             super(kind, pos, end);

Original file line number	Diff line number	Diff line change
`@@ -5817,6 +5817,7 @@ namespace ts {`
`5817`	`5817`	`const typeReferenceDirectives: FileReference[] = [];`
`5818`	`5818`	`const amdDependencies: { path: string; name: string }[] = [];`
`5819`	`5819`	`let amdModuleName: string;`
	`5820`	`+ let hasCheckDirective = false;`
`5820`	`5821`
`5821`	`5822`	`// Keep scanning all the leading trivia in the file until we get to something that`
`5822`	`5823`	`// isn't trivia. Any single line comment will be analyzed to see if it is a`
`@@ -5878,13 +5879,17 @@ namespace ts {`
`5878`	`5879`	`amdDependencies.push(amdDependency);`
`5879`	`5880`	`}`
`5880`	`5881`	`}`
	`5882`	`+`
	`5883`	`+ const checkDirectiveRegEx = /^\/\/\s@check\s/gim;`
	`5884`	`+ hasCheckDirective = hasCheckDirective \|\| !!checkDirectiveRegEx.exec(comment);`
`5881`	`5885`	`}`
`5882`	`5886`	`}`
`5883`	`5887`
`5884`	`5888`	`sourceFile.referencedFiles = referencedFiles;`
`5885`	`5889`	`sourceFile.typeReferenceDirectives = typeReferenceDirectives;`
`5886`	`5890`	`sourceFile.amdDependencies = amdDependencies;`
`5887`	`5891`	`sourceFile.moduleName = amdModuleName;`
	`5892`	`+ sourceFile.hasCheckDirective = hasCheckDirective;`
`5888`	`5893`	`}`
`5889`	`5894`
`5890`	`5895`	`function setExternalModuleIndicator(sourceFile: SourceFile) {`
Original file line number	Diff line number	Diff line change
`@@ -2272,6 +2272,7 @@`
`2272`	`2272`	`/* @internal */ moduleAugmentations: LiteralExpression[];`
`2273`	`2273`	`/* @internal */ patternAmbientModules?: PatternAmbientModule[];`
`2274`	`2274`	`/* @internal */ ambientModuleNames: string[];`
	`2275`	`+ /* @internal */ hasCheckDirective: boolean;`
`2275`	`2276`	`}`
`2276`	`2277`
`2277`	`2278`	`export interface Bundle extends Node {`