Skip to content

Commit 9c853f3

Browse files
a-tarasyuka-tarasyuk
committed
remove tslint:* directive
1 parent 949770a commit 9c853f3

23 files changed

Lines changed: 84 additions & 92 deletions

‎src/compiler/emitter.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,8 @@ namespace ts {
413413
if (emitOnlyDtsFiles && declarationTransform.transformed[0].kind === SyntaxKind.SourceFile) {
414414
// Improved narrowing in master/3.6 makes this cast unnecessary, triggering a lint rule.
415415
// But at the same time, the LKG (3.5) necessitates it because it doesn’t narrow.
416-
// Once the LKG is updated to 3.6, this comment, the cast to `SourceFile`
416+
// Once the LKG is updated to 3.6, this comment, the cast to `SourceFile`, and the eslint directive can be all be removed.
417+
// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
417418
const sourceFile = declarationTransform.transformed[0] as SourceFile;
418419
exportedModulesFromDeclarationEmit = sourceFile.exportedModulesFromDeclarationEmit;
419420
}

‎tests/baselines/reference/callsOnComplexSignatures.symbols‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ function test5() {
259259
>render : Symbol(render, Decl(callsOnComplexSignatures.tsx, 73, 18))
260260
>url : Symbol(url, Decl(callsOnComplexSignatures.tsx, 75, 20))
261261
>React : Symbol(React, Decl(callsOnComplexSignatures.tsx, 1, 6))
262-
>ReactNode : Symbol(React.ReactNode, Decl(react16.d.ts, 216, 49))
262+
>ReactNode : Symbol(React.ReactNode, Decl(react16.d.ts, 213, 49))
263263

264264
const Tag = url ? 'a' : 'button';
265265
>Tag : Symbol(Tag, Decl(callsOnComplexSignatures.tsx, 76, 13))
@@ -276,12 +276,12 @@ function test5() {
276276
>props : Symbol(props, Decl(callsOnComplexSignatures.tsx, 81, 17))
277277
>component : Symbol(component, Decl(callsOnComplexSignatures.tsx, 81, 25))
278278
>React : Symbol(React, Decl(callsOnComplexSignatures.tsx, 1, 6))
279-
>ReactType : Symbol(React.ReactType, Decl(react16.d.ts, 112, 21))
279+
>ReactType : Symbol(React.ReactType, Decl(react16.d.ts, 111, 21))
280280

281281
const Comp: React.ReactType = props.component;
282282
>Comp : Symbol(Comp, Decl(callsOnComplexSignatures.tsx, 82, 13))
283283
>React : Symbol(React, Decl(callsOnComplexSignatures.tsx, 1, 6))
284-
>ReactType : Symbol(React.ReactType, Decl(react16.d.ts, 112, 21))
284+
>ReactType : Symbol(React.ReactType, Decl(react16.d.ts, 111, 21))
285285
>props.component : Symbol(component, Decl(callsOnComplexSignatures.tsx, 81, 25))
286286
>props : Symbol(props, Decl(callsOnComplexSignatures.tsx, 81, 17))
287287
>component : Symbol(component, Decl(callsOnComplexSignatures.tsx, 81, 25))
@@ -319,10 +319,10 @@ function test5() {
319319
var C: React.ComponentType<P1> | React.ComponentType<P2> = null as any;
320320
>C : Symbol(C, Decl(callsOnComplexSignatures.tsx, 98, 11))
321321
>React : Symbol(React, Decl(callsOnComplexSignatures.tsx, 1, 6))
322-
>ComponentType : Symbol(React.ComponentType, Decl(react16.d.ts, 117, 60))
322+
>ComponentType : Symbol(React.ComponentType, Decl(react16.d.ts, 116, 60))
323323
>P1 : Symbol(P1, Decl(callsOnComplexSignatures.tsx, 87, 24))
324324
>React : Symbol(React, Decl(callsOnComplexSignatures.tsx, 1, 6))
325-
>ComponentType : Symbol(React.ComponentType, Decl(react16.d.ts, 117, 60))
325+
>ComponentType : Symbol(React.ComponentType, Decl(react16.d.ts, 116, 60))
326326
>P2 : Symbol(P2, Decl(callsOnComplexSignatures.tsx, 91, 9))
327327

328328
const a = <C p={true} />;

‎tests/baselines/reference/checkJsxChildrenCanBeTupleType.symbols‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,16 @@ interface ResizablePanelProps {
1010
children: [React.ReactNode, React.ReactNode]
1111
>children : Symbol(ResizablePanelProps.children, Decl(checkJsxChildrenCanBeTupleType.tsx, 4, 31))
1212
>React : Symbol(React, Decl(checkJsxChildrenCanBeTupleType.tsx, 2, 6))
13-
>ReactNode : Symbol(React.ReactNode, Decl(react16.d.ts, 216, 49))
13+
>ReactNode : Symbol(React.ReactNode, Decl(react16.d.ts, 213, 49))
1414
>React : Symbol(React, Decl(checkJsxChildrenCanBeTupleType.tsx, 2, 6))
15-
>ReactNode : Symbol(React.ReactNode, Decl(react16.d.ts, 216, 49))
15+
>ReactNode : Symbol(React.ReactNode, Decl(react16.d.ts, 213, 49))
1616
}
1717

1818
class ResizablePanel extends React.Component<
1919
>ResizablePanel : Symbol(ResizablePanel, Decl(checkJsxChildrenCanBeTupleType.tsx, 6, 1))
20-
>React.Component : Symbol(React.Component, Decl(react16.d.ts, 345, 54), Decl(react16.d.ts, 349, 94))
20+
>React.Component : Symbol(React.Component, Decl(react16.d.ts, 342, 54), Decl(react16.d.ts, 345, 94))
2121
>React : Symbol(React, Decl(checkJsxChildrenCanBeTupleType.tsx, 2, 6))
22-
>Component : Symbol(React.Component, Decl(react16.d.ts, 345, 54), Decl(react16.d.ts, 349, 94))
22+
>Component : Symbol(React.Component, Decl(react16.d.ts, 342, 54), Decl(react16.d.ts, 345, 94))
2323

2424
ResizablePanelProps, any> {}
2525
>ResizablePanelProps : Symbol(ResizablePanelProps, Decl(checkJsxChildrenCanBeTupleType.tsx, 2, 25))
@@ -29,10 +29,10 @@ const test = <ResizablePanel>
2929
>ResizablePanel : Symbol(ResizablePanel, Decl(checkJsxChildrenCanBeTupleType.tsx, 6, 1))
3030

3131
<div />
32-
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114))
32+
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2411, 114))
3333

3434
<div />
35-
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114))
35+
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2411, 114))
3636

3737
</ResizablePanel>
3838
>ResizablePanel : Symbol(ResizablePanel, Decl(checkJsxChildrenCanBeTupleType.tsx, 6, 1))
@@ -42,13 +42,13 @@ const testErr = <ResizablePanel>
4242
>ResizablePanel : Symbol(ResizablePanel, Decl(checkJsxChildrenCanBeTupleType.tsx, 6, 1))
4343

4444
<div />
45-
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114))
45+
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2411, 114))
4646

4747
<div />
48-
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114))
48+
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2411, 114))
4949

5050
<div />
51-
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114))
51+
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2411, 114))
5252

5353
</ResizablePanel>
5454
>ResizablePanel : Symbol(ResizablePanel, Decl(checkJsxChildrenCanBeTupleType.tsx, 6, 1))

‎tests/baselines/reference/checkJsxSubtleSkipContextSensitiveBug.symbols‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ interface AsyncLoaderProps<TResult> {
2727
class AsyncLoader<TResult> extends React.Component<AsyncLoaderProps<TResult>> {
2828
>AsyncLoader : Symbol(AsyncLoader, Decl(checkJsxSubtleSkipContextSensitiveBug.tsx, 9, 1))
2929
>TResult : Symbol(TResult, Decl(checkJsxSubtleSkipContextSensitiveBug.tsx, 11, 18))
30-
>React.Component : Symbol(React.Component, Decl(react16.d.ts, 345, 54), Decl(react16.d.ts, 349, 94))
30+
>React.Component : Symbol(React.Component, Decl(react16.d.ts, 342, 54), Decl(react16.d.ts, 345, 94))
3131
>React : Symbol(React, Decl(checkJsxSubtleSkipContextSensitiveBug.tsx, 1, 6))
32-
>Component : Symbol(React.Component, Decl(react16.d.ts, 345, 54), Decl(react16.d.ts, 349, 94))
32+
>Component : Symbol(React.Component, Decl(react16.d.ts, 342, 54), Decl(react16.d.ts, 345, 94))
3333
>AsyncLoaderProps : Symbol(AsyncLoaderProps, Decl(checkJsxSubtleSkipContextSensitiveBug.tsx, 3, 37))
3434
>TResult : Symbol(TResult, Decl(checkJsxSubtleSkipContextSensitiveBug.tsx, 11, 18))
3535

‎tests/baselines/reference/checkJsxUnionSFXContextualTypeInferredCorrectly.symbols‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ export function ComponentWithUnion(props: PM | PS) {
3939
>PS : Symbol(PS, Decl(checkJsxUnionSFXContextualTypeInferredCorrectly.tsx, 2, 26))
4040

4141
return <h1></h1>;
42-
>h1 : Symbol(JSX.IntrinsicElements.h1, Decl(react16.d.ts, 2430, 106))
43-
>h1 : Symbol(JSX.IntrinsicElements.h1, Decl(react16.d.ts, 2430, 106))
42+
>h1 : Symbol(JSX.IntrinsicElements.h1, Decl(react16.d.ts, 2421, 106))
43+
>h1 : Symbol(JSX.IntrinsicElements.h1, Decl(react16.d.ts, 2421, 106))
4444
}
4545

4646
// Usage with React tsx

‎tests/baselines/reference/forLoopEndingMultilineComments.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ export function consoleTestResultHandler(testResult: any): boolean {
88
for (const q of a) {
99
void a;
1010

11-
/* tslint:disable:no-console */
11+
/* eslint-disable no-console */
1212
if (a) {
1313
} else {
1414
}
15-
/* tslint:enable:no-console */
15+
/* eslint-enable no-console */
1616
}
1717

1818
return true;
@@ -27,12 +27,12 @@ function consoleTestResultHandler(testResult) {
2727
for (var _i = 0, a_1 = a; _i < a_1.length; _i++) {
2828
var q = a_1[_i];
2929
void a;
30-
/* tslint:disable:no-console */
30+
/* eslint-disable no-console */
3131
if (a) {
3232
}
3333
else {
3434
}
35-
/* tslint:enable:no-console */
35+
/* eslint-enable no-console */
3636
}
3737
return true;
3838
}

‎tests/baselines/reference/forLoopEndingMultilineComments.symbols‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ export function consoleTestResultHandler(testResult: any): boolean {
1717
void a;
1818
>a : Symbol(a, Decl(forLoopEndingMultilineComments.ts, 0, 11))
1919

20-
/* tslint:disable:no-console */
20+
/* eslint-disable no-console */
2121
if (a) {
2222
>a : Symbol(a, Decl(forLoopEndingMultilineComments.ts, 0, 11))
2323

2424
} else {
2525
}
26-
/* tslint:enable:no-console */
26+
/* eslint-enable no-console */
2727
}
2828

2929
return true;

‎tests/baselines/reference/forLoopEndingMultilineComments.types‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ export function consoleTestResultHandler(testResult: any): boolean {
1919
>void a : undefined
2020
>a : any
2121

22-
/* tslint:disable:no-console */
22+
/* eslint-disable no-console */
2323
if (a) {
2424
>a : any
2525

2626
} else {
2727
}
28-
/* tslint:enable:no-console */
28+
/* eslint-enable no-console */
2929
}
3030

3131
return true;

‎tests/baselines/reference/jsxChildrenSingleChildConfusableWithMultipleChildrenNoError.symbols‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import * as React from 'react'
77
type Tab = [string, React.ReactNode] // [tabName, tabContent]
88
>Tab : Symbol(Tab, Decl(jsxChildrenSingleChildConfusableWithMultipleChildrenNoError.tsx, 2, 30))
99
>React : Symbol(React, Decl(jsxChildrenSingleChildConfusableWithMultipleChildrenNoError.tsx, 2, 6))
10-
>ReactNode : Symbol(React.ReactNode, Decl(react16.d.ts, 216, 49))
10+
>ReactNode : Symbol(React.ReactNode, Decl(react16.d.ts, 213, 49))
1111

1212
interface Props {
1313
>Props : Symbol(Props, Decl(jsxChildrenSingleChildConfusableWithMultipleChildrenNoError.tsx, 4, 36))
@@ -23,14 +23,14 @@ function TabLayout(props: Props) {
2323
>Props : Symbol(Props, Decl(jsxChildrenSingleChildConfusableWithMultipleChildrenNoError.tsx, 4, 36))
2424

2525
return <div/>
26-
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114))
26+
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2411, 114))
2727
}
2828

2929
export class App extends React.Component<{}> {
3030
>App : Symbol(App, Decl(jsxChildrenSingleChildConfusableWithMultipleChildrenNoError.tsx, 12, 1))
31-
>React.Component : Symbol(React.Component, Decl(react16.d.ts, 345, 54), Decl(react16.d.ts, 349, 94))
31+
>React.Component : Symbol(React.Component, Decl(react16.d.ts, 342, 54), Decl(react16.d.ts, 345, 94))
3232
>React : Symbol(React, Decl(jsxChildrenSingleChildConfusableWithMultipleChildrenNoError.tsx, 2, 6))
33-
>Component : Symbol(React.Component, Decl(react16.d.ts, 345, 54), Decl(react16.d.ts, 349, 94))
33+
>Component : Symbol(React.Component, Decl(react16.d.ts, 342, 54), Decl(react16.d.ts, 345, 94))
3434

3535
render() {
3636
>render : Symbol(App.render, Decl(jsxChildrenSingleChildConfusableWithMultipleChildrenNoError.tsx, 14, 46))
@@ -40,10 +40,10 @@ export class App extends React.Component<{}> {
4040

4141
{[
4242
['Users', <div/>],
43-
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114))
43+
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2411, 114))
4444

4545
['Products', <div/>]
46-
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114))
46+
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2411, 114))
4747

4848
]}
4949
</TabLayout>

‎tests/baselines/reference/jsxImportForSideEffectsNonExtantNoError.symbols‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ import "./App.css"; // doesn't actually exist
77

88
const tag = <div></div>;
99
>tag : Symbol(tag, Decl(jsxImportForSideEffectsNonExtantNoError.tsx, 5, 5))
10-
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114))
11-
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114))
10+
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2411, 114))
11+
>div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2411, 114))
1212

0 commit comments

Comments
 (0)