Add semicolon to unused class member list

sandersn · sandersn · commit 97fb0fd55f28 · 2018-01-22T12:59:53.000-08:00
Turns out SemicolonClassElement is a specific kind for semicolons inside a class. Having one of them with --noUnusedLocals on would crash the compiler after the assert added in microsoft#21013.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -21030,6 +21030,7 @@ namespace ts {
                             }
                             break;
                         case SyntaxKind.IndexSignature:
+                        case SyntaxKind.SemicolonClassElement:
                             // Can't be private
                             break;
                         default:
diff --git a/tests/baselines/reference/unusedSemicolonInClass.js b/tests/baselines/reference/unusedSemicolonInClass.js
@@ -0,0 +1,13 @@
+//// [unusedSemicolonInClass.ts]
+class Unused {
+    ;
+}
+
+
+//// [unusedSemicolonInClass.js]
+var Unused = /** @class */ (function () {
+    function Unused() {
+    }
+    ;
+    return Unused;
+}());
diff --git a/tests/baselines/reference/unusedSemicolonInClass.symbols b/tests/baselines/reference/unusedSemicolonInClass.symbols
@@ -0,0 +1,7 @@
+=== tests/cases/compiler/unusedSemicolonInClass.ts ===
+class Unused {
+>Unused : Symbol(Unused, Decl(unusedSemicolonInClass.ts, 0, 0))
+
+    ;
+}
+
diff --git a/tests/baselines/reference/unusedSemicolonInClass.types b/tests/baselines/reference/unusedSemicolonInClass.types
@@ -0,0 +1,7 @@
+=== tests/cases/compiler/unusedSemicolonInClass.ts ===
+class Unused {
+>Unused : Unused
+
+    ;
+}
+
diff --git a/tests/cases/compiler/unusedSemicolonInClass.ts b/tests/cases/compiler/unusedSemicolonInClass.ts
@@ -0,0 +1,4 @@
+// @noUnusedLocals: true
+class Unused {
+    ;
+}

Original file line number	Diff line number	Diff line change
`@@ -21030,6 +21030,7 @@ namespace ts {`
`21030`	`21030`	`}`
`21031`	`21031`	`break;`
`21032`	`21032`	`case SyntaxKind.IndexSignature:`
	`21033`	`+ case SyntaxKind.SemicolonClassElement:`
`21033`	`21034`	`// Can't be private`
`21034`	`21035`	`break;`
`21035`	`21036`	`default:`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +// @noUnusedLocals: true
 +class Unused {
 +    ;
 +}