Respond to code review comments

mhegazy · mhegazy · commit 97cd7bf5af7b · 2017-10-27T10:14:21.000-07:00
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -1710,7 +1710,7 @@ namespace ts {
         return moduleResolution;
     }
 
-    export function getStrictOptionValue(compilerOptions: CompilerOptions, flag: "noImplicitAny" | "noImplicitThis" | "strictNullChecks" | "strictFunctionTypes" | "alwaysStrict"): boolean {
+    export function getStrictOptionValue(compilerOptions: CompilerOptions, flag: StrictOptionName): boolean {
         return compilerOptions[flag] === undefined ? compilerOptions.strict : compilerOptions[flag];
     }
 
diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -3676,6 +3676,8 @@ namespace ts {
 
     export type CompilerOptionsValue = string | number | boolean | (string | number)[] | string[] | MapLike<string[]> | PluginImport[] | null | undefined;
 
+    export type StrictOptionName = "noImplicitAny" | "noImplicitThis" | "strictNullChecks" | "strictFunctionTypes" | "alwaysStrict";
+
     export interface CompilerOptions {
         /*@internal*/ all?: boolean;
         allowJs?: boolean;

Original file line number	Diff line number	Diff line change
`@@ -1710,7 +1710,7 @@ namespace ts {`
`1710`	`1710`	`return moduleResolution;`
`1711`	`1711`	`}`
`1712`	`1712`
`1713`		`- export function getStrictOptionValue(compilerOptions: CompilerOptions, flag: "noImplicitAny" \| "noImplicitThis" \| "strictNullChecks" \| "strictFunctionTypes" \| "alwaysStrict"): boolean {`
	`1713`	`+ export function getStrictOptionValue(compilerOptions: CompilerOptions, flag: StrictOptionName): boolean {`
`1714`	`1714`	`return compilerOptions[flag] === undefined ? compilerOptions.strict : compilerOptions[flag];`
`1715`	`1715`	`}`
`1716`	`1716`