Don't implicit-any diagnostic for json module

Andy Hanson · Andy Hanson · commit 96f9e076f88e · 2018-09-26T13:50:37.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -2241,7 +2241,7 @@ namespace ts {
             const sourceFile = resolvedModule && !resolutionDiagnostic && host.getSourceFile(resolvedModule.resolvedFileName);
             if (sourceFile) {
                 if (sourceFile.symbol) {
-                    if (resolvedModule.isExternalLibraryImport && !extensionIsTS(resolvedModule.extension)) {
+                    if (resolvedModule.isExternalLibraryImport && !resolutionExtensionIsTSOrJson(resolvedModule.extension)) {
                         errorOnImplicitAnyModule(/*isError*/ false, errorNode, resolvedModule, moduleReference);
                     }
                     // merged symbol is module declaration symbol combined with all augmentations
diff --git a/tests/cases/fourslash/codeFixCannotFindModule_suggestion_falsePositive.ts b/tests/cases/fourslash/codeFixCannotFindModule_suggestion_falsePositive.ts
@@ -0,0 +1,16 @@
+/// <reference path='fourslash.ts' />
+
+// @moduleResolution: node
+// @resolveJsonModule: true
+// @strict: true
+
+// @Filename: /node_modules/foo/bar.json
+////export const x = 0;
+
+// @Filename: /a.ts
+////import abs = require([|"foo/bar.json"|]);
+////abs;
+
+verify.noErrors();
+goTo.file("/a.ts");
+verify.getSuggestionDiagnostics([]);

Original file line number	Diff line number	Diff line change
`@@ -2241,7 +2241,7 @@ namespace ts {`
`2241`	`2241`	`const sourceFile = resolvedModule && !resolutionDiagnostic && host.getSourceFile(resolvedModule.resolvedFileName);`
`2242`	`2242`	`if (sourceFile) {`
`2243`	`2243`	`if (sourceFile.symbol) {`
`2244`		`- if (resolvedModule.isExternalLibraryImport && !extensionIsTS(resolvedModule.extension)) {`
	`2244`	`+ if (resolvedModule.isExternalLibraryImport && !resolutionExtensionIsTSOrJson(resolvedModule.extension)) {`
`2245`	`2245`	`errorOnImplicitAnyModule(/isError/ false, errorNode, resolvedModule, moduleReference);`
`2246`	`2246`	`}`
`2247`	`2247`	`// merged symbol is module declaration symbol combined with all augmentations`