Use 'lastOrUndefined' where appropriate in the services layer.

DanielRosenwasser · DanielRosenwasser · commit 9460fb580d36 · 2015-05-01T18:34:37.000-07:00
diff --git a/src/services/breakpoints.ts b/src/services/breakpoints.ts
@@ -446,14 +446,14 @@ module ts.BreakpointResolver {
                         // fall through.
 
                     case SyntaxKind.CatchClause:
-                        return spanInNode((<Block>node.parent).statements[(<Block>node.parent).statements.length - 1]);;
+                        return spanInNode(lastOrUndefined((<Block>node.parent).statements));;
 
                     case SyntaxKind.CaseBlock:
                         // breakpoint in last statement of the last clause
                         let caseBlock = <CaseBlock>node.parent;
-                        let lastClause = caseBlock.clauses[caseBlock.clauses.length - 1];
+                        let lastClause = lastOrUndefined(caseBlock.clauses);
                         if (lastClause) {
-                            return spanInNode(lastClause.statements[lastClause.statements.length - 1]);
+                            return spanInNode(lastOrUndefined(lastClause.statements));
                         }
                         return undefined;
 
diff --git a/src/services/formatting/formattingScanner.ts b/src/services/formatting/formattingScanner.ts
@@ -51,7 +51,7 @@ module ts.formatting {
             if (isStarted) {
                 if (trailingTrivia) {
                     Debug.assert(trailingTrivia.length !== 0);
-                    wasNewLine = trailingTrivia[trailingTrivia.length - 1].kind === SyntaxKind.NewLineTrivia;
+                    wasNewLine = lastOrUndefined(trailingTrivia).kind === SyntaxKind.NewLineTrivia;
                 }
                 else {
                     wasNewLine = false;
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -848,7 +848,7 @@ module ts {
                                 // Overwrite the last declaration if it was an overload
                                 // and this one is an implementation.
                                 if (functionDeclaration.body && !(<FunctionLikeDeclaration>lastDeclaration).body) {
-                                    declarations[declarations.length - 1] = functionDeclaration;
+                                    lastOrUndefined(declarations) = functionDeclaration;
                                 }
                             }
                             else {
@@ -4058,7 +4058,7 @@ module ts {
                     return true;
                 }
                 else if (declarations.length) {
-                    result.push(createDefinitionInfo(declarations[declarations.length - 1], symbolKind, symbolName, containerName));
+                    result.push(createDefinitionInfo(lastOrUndefined(declarations), symbolKind, symbolName, containerName));
                     return true;
                 }
 
diff --git a/src/services/utilities.ts b/src/services/utilities.ts
@@ -200,7 +200,7 @@ module ts {
     function nodeEndsWith(n: Node, expectedLastToken: SyntaxKind, sourceFile: SourceFile): boolean {
         let children = n.getChildren(sourceFile);
         if (children.length) {
-            let last = children[children.length - 1];
+            let last = lastOrUndefined(children);
             if (last.kind === expectedLastToken) {
                 return true;
             }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ module ts.formatting {`
`51`	`51`	`if (isStarted) {`
`52`	`52`	`if (trailingTrivia) {`
`53`	`53`	`Debug.assert(trailingTrivia.length !== 0);`
`54`		`- wasNewLine = trailingTrivia[trailingTrivia.length - 1].kind === SyntaxKind.NewLineTrivia;`
	`54`	`+ wasNewLine = lastOrUndefined(trailingTrivia).kind === SyntaxKind.NewLineTrivia;`
`55`	`55`	`}`
`56`	`56`	`else {`
`57`	`57`	`wasNewLine = false;`
Original file line number	Diff line number	Diff line change
`@@ -848,7 +848,7 @@ module ts {`
`848`	`848`	`// Overwrite the last declaration if it was an overload`
`849`	`849`	`// and this one is an implementation.`
`850`	`850`	`if (functionDeclaration.body && !(<FunctionLikeDeclaration>lastDeclaration).body) {`
`851`		`- declarations[declarations.length - 1] = functionDeclaration;`
	`851`	`+ lastOrUndefined(declarations) = functionDeclaration;`
`852`	`852`	`}`
`853`	`853`	`}`
`854`	`854`	`else {`
`@@ -4058,7 +4058,7 @@ module ts {`
`4058`	`4058`	`return true;`
`4059`	`4059`	`}`
`4060`	`4060`	`else if (declarations.length) {`
`4061`		`- result.push(createDefinitionInfo(declarations[declarations.length - 1], symbolKind, symbolName, containerName));`
	`4061`	`+ result.push(createDefinitionInfo(lastOrUndefined(declarations), symbolKind, symbolName, containerName));`
`4062`	`4062`	`return true;`
`4063`	`4063`	`}`
`4064`	`4064`
Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ module ts {`
`200`	`200`	`function nodeEndsWith(n: Node, expectedLastToken: SyntaxKind, sourceFile: SourceFile): boolean {`
`201`	`201`	`let children = n.getChildren(sourceFile);`
`202`	`202`	`if (children.length) {`
`203`		`- let last = children[children.length - 1];`
	`203`	`+ let last = lastOrUndefined(children);`
`204`	`204`	`if (last.kind === expectedLastToken) {`
`205`	`205`	`return true;`
`206`	`206`	`}`