getAllJSDocTagsOfKind always returns a defined result (microsoft#22652)

Andy · web-flow · commit 92ec1149ac5c · 2018-03-16T14:01:28.000-07:00
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -4542,7 +4542,7 @@ namespace ts {
     }
 
     /** Gets all JSDoc tags of a specified kind, or undefined if not present. */
-    export function getAllJSDocTagsOfKind(node: Node, kind: SyntaxKind): ReadonlyArray<JSDocTag> | undefined {
+    export function getAllJSDocTagsOfKind(node: Node, kind: SyntaxKind): ReadonlyArray<JSDocTag> {
         return getJSDocTags(node).filter(doc => doc.kind === kind);
     }
 }
diff --git a/tests/baselines/reference/api/tsserverlibrary.d.ts b/tests/baselines/reference/api/tsserverlibrary.d.ts
@@ -3037,7 +3037,7 @@ declare namespace ts {
     /** Get all JSDoc tags related to a node, including those on parent nodes. */
     function getJSDocTags(node: Node): ReadonlyArray<JSDocTag>;
     /** Gets all JSDoc tags of a specified kind, or undefined if not present. */
-    function getAllJSDocTagsOfKind(node: Node, kind: SyntaxKind): ReadonlyArray<JSDocTag> | undefined;
+    function getAllJSDocTagsOfKind(node: Node, kind: SyntaxKind): ReadonlyArray<JSDocTag>;
 }
 declare namespace ts {
     function isNumericLiteral(node: Node): node is NumericLiteral;
diff --git a/tests/baselines/reference/api/typescript.d.ts b/tests/baselines/reference/api/typescript.d.ts
@@ -3092,7 +3092,7 @@ declare namespace ts {
     /** Get all JSDoc tags related to a node, including those on parent nodes. */
     function getJSDocTags(node: Node): ReadonlyArray<JSDocTag>;
     /** Gets all JSDoc tags of a specified kind, or undefined if not present. */
-    function getAllJSDocTagsOfKind(node: Node, kind: SyntaxKind): ReadonlyArray<JSDocTag> | undefined;
+    function getAllJSDocTagsOfKind(node: Node, kind: SyntaxKind): ReadonlyArray<JSDocTag>;
 }
 declare namespace ts {
     function isNumericLiteral(node: Node): node is NumericLiteral;

Original file line number	Diff line number	Diff line change
`@@ -4542,7 +4542,7 @@ namespace ts {`
`4542`	`4542`	`}`
`4543`	`4543`
`4544`	`4544`	`/** Gets all JSDoc tags of a specified kind, or undefined if not present. */`
`4545`		`- export function getAllJSDocTagsOfKind(node: Node, kind: SyntaxKind): ReadonlyArray<JSDocTag> \| undefined {`
	`4545`	`+ export function getAllJSDocTagsOfKind(node: Node, kind: SyntaxKind): ReadonlyArray<JSDocTag> {`
`4546`	`4546`	`return getJSDocTags(node).filter(doc => doc.kind === kind);`
`4547`	`4547`	`}`
`4548`	`4548`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3037,7 +3037,7 @@ declare namespace ts {`
`3037`	`3037`	`/** Get all JSDoc tags related to a node, including those on parent nodes. */`
`3038`	`3038`	`function getJSDocTags(node: Node): ReadonlyArray<JSDocTag>;`
`3039`	`3039`	`/** Gets all JSDoc tags of a specified kind, or undefined if not present. */`
`3040`		`- function getAllJSDocTagsOfKind(node: Node, kind: SyntaxKind): ReadonlyArray<JSDocTag> \| undefined;`
	`3040`	`+ function getAllJSDocTagsOfKind(node: Node, kind: SyntaxKind): ReadonlyArray<JSDocTag>;`
`3041`	`3041`	`}`
`3042`	`3042`	`declare namespace ts {`
`3043`	`3043`	`function isNumericLiteral(node: Node): node is NumericLiteral;`
Original file line number	Diff line number	Diff line change
`@@ -3092,7 +3092,7 @@ declare namespace ts {`
`3092`	`3092`	`/** Get all JSDoc tags related to a node, including those on parent nodes. */`
`3093`	`3093`	`function getJSDocTags(node: Node): ReadonlyArray<JSDocTag>;`
`3094`	`3094`	`/** Gets all JSDoc tags of a specified kind, or undefined if not present. */`
`3095`		`- function getAllJSDocTagsOfKind(node: Node, kind: SyntaxKind): ReadonlyArray<JSDocTag> \| undefined;`
	`3095`	`+ function getAllJSDocTagsOfKind(node: Node, kind: SyntaxKind): ReadonlyArray<JSDocTag>;`
`3096`	`3096`	`}`
`3097`	`3097`	`declare namespace ts {`
`3098`	`3098`	`function isNumericLiteral(node: Node): node is NumericLiteral;`