Skip to content

Commit 9006b44

Browse files
committed
CR feedback
1 parent 1a0299d commit 9006b44

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/compiler/checker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7888,7 +7888,7 @@ namespace ts {
78887888
// assignable to the JSX Element Type
78897889
const callSignature = getSingleCallSignature(getTypeOfSymbol(sym));
78907890
const callReturnType = callSignature && getReturnTypeOfSignature(callSignature);
7891-
let paramType = callReturnType && callSignature && (callSignature.parameters.length === 0 ? emptyObjectType : getTypeOfSymbol(callSignature.parameters[0]));
7891+
let paramType = callReturnType && (callSignature.parameters.length === 0 ? emptyObjectType : getTypeOfSymbol(callSignature.parameters[0]));
78927892
if (callReturnType && isTypeAssignableTo(callReturnType, jsxElementType) && (paramType.flags & TypeFlags.ObjectType)) {
78937893
// Intersect in JSX.IntrinsicAttributes if it exists
78947894
const intrinsicAttributes = getJsxType(JsxNames.IntrinsicAttributes);

src/harness/harness.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1119,10 +1119,10 @@ namespace Harness {
11191119

11201120
// Files from tests\lib that are requested by "@libFiles"
11211121
if (options.libFiles) {
1122-
ts.forEach(options.libFiles.split(","), filename => {
1123-
const libFileName = "tests/lib/" + filename;
1122+
for (const fileName of options.libFiles.split(",")) {
1123+
const libFileName = "tests/lib/" + fileName;
11241124
includeBuiltFiles.push({ unitName: libFileName, content: normalizeLineEndings(IO.readFile(libFileName), newLine) });
1125-
});
1125+
}
11261126
}
11271127

11281128

0 commit comments

Comments
 (0)