Mark IIFE signature with anySignature during contextual typing

sandersn · sandersn · commit 8e668441b33d · 2016-05-19T12:33:37.000-07:00
Avoids recursion -- during batch compilation, `checkCallExpression` already
sets the signature to `anySignature` as a sentinel value, the services
layer calls directly into `checkParameter`, skipping `checkCallExpression`
entirely. So `getContextuallyTypedParameterType` also needs to set this
sentinel value.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -8606,7 +8606,12 @@ namespace ts {
                             }
                             return createArrayType(getUnionType(restTypes));
                         }
-                        return checkExpression(iife.arguments[indexOfParameter]);
+                        const links = getNodeLinks(iife);
+                        const cached = links.resolvedSignature;
+                        links.resolvedSignature = anySignature;
+                        const type = checkExpression(iife.arguments[indexOfParameter]);
+                        links.resolvedSignature = cached;
+                        return type;
                     }
                 }
                 const contextualSignature = getContextualSignature(func);
diff --git a/tests/cases/fourslash/quickInfoForContextuallyTypedIife.ts b/tests/cases/fourslash/quickInfoForContextuallyTypedIife.ts
@@ -0,0 +1,38 @@
+/// <reference path='fourslash.ts' />
+
+////(({ q/*1*/, qq/*2*/ }, x/*3*/, { p/*4*/ }) => {
+////    var s: number = q/*5*/;
+////    var t: number = qq/*6*/;
+////    var u: number = p/*7*/;
+////    var v: number = x/*8*/;
+////    return q; })({ q: 13, qq: 12 }, 1, { p: 14 });
+////((a/*9*/, b/*10*/, c/*11*/) => [a/*12*/,b/*13*/,c/*14*/])("foo", 101, false);
+
+goTo.marker('1');
+verify.quickInfoIs("var q: number");
+goTo.marker('2');
+verify.quickInfoIs("var qq: number");
+goTo.marker('3');
+verify.quickInfoIs("(parameter) x: number");
+goTo.marker('4');
+verify.quickInfoIs("var p: number");
+goTo.marker('5');
+verify.quickInfoIs("var q: number");
+goTo.marker('6');
+verify.quickInfoIs("var qq: number");
+goTo.marker('7');
+verify.quickInfoIs("var p: number");
+goTo.marker('8');
+verify.quickInfoIs("(parameter) x: number");
+goTo.marker('9');
+verify.quickInfoIs("(parameter) a: string");
+goTo.marker('10');
+verify.quickInfoIs("(parameter) b: number");
+goTo.marker('11');
+verify.quickInfoIs("(parameter) c: boolean");
+goTo.marker('12');
+verify.quickInfoIs("(parameter) a: string");
+goTo.marker('13');
+verify.quickInfoIs("(parameter) b: number");
+goTo.marker('14');
+verify.quickInfoIs("(parameter) c: boolean");

Original file line number	Diff line number	Diff line change
`@@ -8606,7 +8606,12 @@ namespace ts {`
`8606`	`8606`	`}`
`8607`	`8607`	`return createArrayType(getUnionType(restTypes));`
`8608`	`8608`	`}`
`8609`		`- return checkExpression(iife.arguments[indexOfParameter]);`
	`8609`	`+ const links = getNodeLinks(iife);`
	`8610`	`+ const cached = links.resolvedSignature;`
	`8611`	`+ links.resolvedSignature = anySignature;`
	`8612`	`+ const type = checkExpression(iife.arguments[indexOfParameter]);`
	`8613`	`+ links.resolvedSignature = cached;`
	`8614`	`+ return type;`
`8610`	`8615`	`}`
`8611`	`8616`	`}`
`8612`	`8617`	`const contextualSignature = getContextualSignature(func);`