Do not query for bind errors if skipLibCheck or skipDefaultLibCheck is set

mhegazy · mhegazy · commit 8c33a792b329 · 2017-04-18T16:19:58.000-07:00
diff --git a/src/compiler/program.ts b/src/compiler/program.ts
@@ -908,6 +908,13 @@ namespace ts {
 
         function getSemanticDiagnosticsForFileNoCache(sourceFile: SourceFile, cancellationToken: CancellationToken): Diagnostic[] {
             return runWithCancellationToken(() => {
+                // If skipLibCheck is enabled, skip reporting errors if file is a declaration file.
+                // If skipDefaultLibCheck is enabled, skip reporting errors if file contains a
+                // '/// <reference no-default-lib="true"/>' directive.
+                if (options.skipLibCheck && sourceFile.isDeclarationFile || options.skipDefaultLibCheck && sourceFile.hasNoDefaultLib) {
+                    return emptyArray;
+                }
+
                 const typeChecker = getDiagnosticsProducingTypeChecker();
 
                 Debug.assert(!!sourceFile.bindDiagnostics);
diff --git a/tests/cases/compiler/noDefaultLib.ts b/tests/cases/compiler/noDefaultLib.ts
@@ -1,3 +1,4 @@
+// @skipDefaultLibCheck: false
 /// <reference no-default-lib="true"/>
 var x;
 
diff --git a/tests/cases/compiler/variableDeclarationInStrictMode1.ts b/tests/cases/compiler/variableDeclarationInStrictMode1.ts
@@ -1,2 +1,3 @@
+// @skipDefaultLibCheck: false
 "use strict";
 var eval;

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// @skipDefaultLibCheck: false`
`1`	`2`	`/// <reference no-default-lib="true"/>`
`2`	`3`	`var x;`
`3`	`4`