Avoid using old node in import fix to use namespace import (microsoft#25729)

Andy · web-flow · commit 89f2af17f07e · 2018-07-17T13:34:56.000-07:00
diff --git a/src/services/codefixes/importFixes.ts b/src/services/codefixes/importFixes.ts
@@ -482,7 +482,7 @@ namespace ts.codefix {
     }
 
     function addNamespaceQualifier(changes: textChanges.ChangeTracker, sourceFile: SourceFile, { namespacePrefix, symbolToken }: FixUseNamespaceImport): void {
-        changes.replaceNode(sourceFile, symbolToken, createPropertyAccess(createIdentifier(namespacePrefix), symbolToken));
+        changes.replaceNode(sourceFile, symbolToken, createPropertyAccess(createIdentifier(namespacePrefix), createIdentifier(symbolToken.text)));
     }
 
     interface ImportsCollection {
diff --git a/tests/cases/fourslash/importNameCodeFixExistingImport2.ts b/tests/cases/fourslash/importNameCodeFixExistingImport2.ts
@@ -1,16 +1,19 @@
 /// <reference path="fourslash.ts" />
 
-//// [|import * as ns from "./module";
-//// f1/*0*/();|]
+////import * as ns from "./module";
+////// Comment
+////f1/*0*/();
 
 // @Filename: module.ts
 //// export function f1() {}
 //// export var v1 = 5;
 
 verify.importFixAtPosition([
 `import * as ns from "./module";
+// Comment
 ns.f1();`,
 `import * as ns from "./module";
 import { f1 } from "./module";
+// Comment
 f1();`,
 ]);

Original file line number	Diff line number	Diff line change
`@@ -482,7 +482,7 @@ namespace ts.codefix {`
`482`	`482`	`}`
`483`	`483`
`484`	`484`	`function addNamespaceQualifier(changes: textChanges.ChangeTracker, sourceFile: SourceFile, { namespacePrefix, symbolToken }: FixUseNamespaceImport): void {`
`485`		`- changes.replaceNode(sourceFile, symbolToken, createPropertyAccess(createIdentifier(namespacePrefix), symbolToken));`
	`485`	`+ changes.replaceNode(sourceFile, symbolToken, createPropertyAccess(createIdentifier(namespacePrefix), createIdentifier(symbolToken.text)));`
`486`	`486`	`}`
`487`	`487`
`488`	`488`	`interface ImportsCollection {`