Fix comment

Yui T · Yui T · commit 880e958d118d · 2014-11-14T16:30:03.000-08:00
diff --git a/src/compiler/emitter.ts b/src/compiler/emitter.ts
@@ -1047,7 +1047,8 @@ module ts {
                     // Emit identifier as an identifier
                     emit(node.name);
                     write(": ");
-                    // Even though this is stored as identified because it is in short-hand property assignment, treated it as expression 
+                    // Even though this is stored as identified because it is in short-hand property assignment,
+                    // treated it as expression 
                     emitExpressionIdentifier(node.name);
                     emitTrailingComments(node);
                 }
diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts
@@ -2687,6 +2687,7 @@ module ts {
                 (<PropertyDeclaration>node).initializer = makeFunctionExpression(SyntaxKind.FunctionExpression, node.pos, undefined, sig, body);
                 return finishNode(node);
             }
+            // Disallow optional property assignment
             if (token === SyntaxKind.QuestionToken) {
                 var questionStart = scanner.getTokenPos();
                 grammarErrorAtPos(questionStart, scanner.getStartPos() - questionStart, Diagnostics.A_object_member_cannot_be_declared_optional);
diff --git a/tests/baselines/reference/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.errors.txt b/tests/baselines/reference/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.errors.txt
@@ -11,13 +11,14 @@ tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPr
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(16,6): error TS1005: ',' expected.
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(17,6): error TS1005: '=' expected.
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(18,1): error TS1128: Declaration or statement expected.
+tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(20,17): error TS1005: ':' expected.
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(5,9): error TS2378: A 'get' accessor must return a value or consist of a single 'throw' statement.
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(15,5): error TS2300: Duplicate identifier 'a'.
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(15,7): error TS2304: Cannot find name 'b'.
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(16,5): error TS2300: Duplicate identifier 'a'.
 
 
-==== tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts (17 errors) ====
+==== tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts (18 errors) ====
     // errors
     var y = {
         "stringLiteral",
@@ -69,4 +70,8 @@ tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPr
 !!! error TS1005: '=' expected.
     };
     ~
-!!! error TS1128: Declaration or statement expected.
+!!! error TS1128: Declaration or statement expected.
+    
+    var v = { class };  // error
+                    ~
+!!! error TS1005: ':' expected.
diff --git a/tests/baselines/reference/objectLiteralShorthandPropertiesErrorWithModule.errors.txt b/tests/baselines/reference/objectLiteralShorthandPropertiesErrorWithModule.errors.txt
@@ -0,0 +1,24 @@
+tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorWithModule.ts(10,10): error TS1005: ',' expected.
+tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorWithModule.ts(14,3): error TS2339: Property 'y' does not exist on type 'typeof m'.
+
+
+==== tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorWithModule.ts (2 errors) ====
+    // module export
+    var x = "Foo";
+    module m {
+        export var x;
+    }
+    
+    module n {
+        var z = 10000;
+        export var y = {
+            m.x  // error
+             ~
+!!! error TS1005: ',' expected.
+        };
+    }
+    
+    m.y.x;
+      ~
+!!! error TS2339: Property 'y' does not exist on type 'typeof m'.
+    
diff --git a/tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts b/tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts
@@ -15,4 +15,6 @@ var x = {
     a.b,
     a["ss"],
     a[1],
-};
+};
+
+var v = { class };  // error
diff --git a/tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorWithModule.ts b/tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorWithModule.ts
@@ -0,0 +1,14 @@
+// module export
+var x = "Foo";
+module m {
+    export var x;
+}
+
+module n {
+    var z = 10000;
+    export var y = {
+        m.x  // error
+    };
+}
+
+m.y.x;
diff --git a/tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesWithModule.ts b/tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesWithModule.ts
@@ -1,14 +1,13 @@
 // module export
-var x = "Foo";
+
 module m {
     export var x;
 }
 
 module m {
-    var z = 10000;
-    export var y = {
+    var z = x;
+    var y = {
+        a: x,
         x
     };
 }
-
-m.y.x;

Original file line number	Diff line number	Diff line change
`@@ -2687,6 +2687,7 @@ module ts {`
`2687`	`2687`	`(<PropertyDeclaration>node).initializer = makeFunctionExpression(SyntaxKind.FunctionExpression, node.pos, undefined, sig, body);`
`2688`	`2688`	`return finishNode(node);`
`2689`	`2689`	`}`
	`2690`	`+ // Disallow optional property assignment`
`2690`	`2691`	`if (token === SyntaxKind.QuestionToken) {`
`2691`	`2692`	`var questionStart = scanner.getTokenPos();`
`2692`	`2693`	`grammarErrorAtPos(questionStart, scanner.getStartPos() - questionStart, Diagnostics.A_object_member_cannot_be_declared_optional);`
Original file line number	Diff line number	Diff line change
`@@ -1,14 +1,13 @@`
`1`	`1`	`// module export`
`2`		`-var x = "Foo";`
	`2`	`+`
`3`	`3`	`module m {`
`4`	`4`	`export var x;`
`5`	`5`	`}`
`6`	`6`
`7`	`7`	`module m {`
`8`		`- var z = 10000;`
`9`		`- export var y = {`
	`8`	`+ var z = x;`
	`9`	`+ var y = {`
	`10`	`+ a: x,`
`10`	`11`	`x`
`11`	`12`	`};`
`12`	`13`	`}`
`13`		`-`
`14`		`-m.y.x;`