Adding comment and removing unnecessary object creation

riknoll · riknoll · commit 8728b9857d2f · 2016-09-02T16:44:25.000-07:00
diff --git a/src/server/client.ts b/src/server/client.ts
@@ -216,15 +216,17 @@ namespace ts.server {
             return {
                 isMemberCompletion: false,
                 isNewIdentifierLocation: false,
-                entries: response.body.map(({ name, kind, kindModifiers, sortText, replacementSpan }) => {
+                entries: response.body.map(entry => {
 
-                    let convertedSpan: TextSpan;
-                    if (replacementSpan) {
-                        convertedSpan = createTextSpanFromBounds(this.lineOffsetToPosition(fileName, replacementSpan.start),
+                    if (entry.replacementSpan !== undefined) {
+                        const { name, kind, kindModifiers, sortText, replacementSpan} = entry;
+
+                        const convertedSpan = createTextSpanFromBounds(this.lineOffsetToPosition(fileName, replacementSpan.start),
                             this.lineOffsetToPosition(fileName, replacementSpan.end));
+                        return { name, kind, kindModifiers, sortText, replacementSpan: convertedSpan };
                     }
 
-                    return { name, kind, kindModifiers, sortText, replacementSpan: convertedSpan };
+                    return entry as { name: string, kind: string, kindModifiers: string, sortText: string };
                 })
             };
         }
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -1488,6 +1488,11 @@ namespace ts {
         kind: string;            // see ScriptElementKind
         kindModifiers: string;   // see ScriptElementKindModifier, comma separated
         sortText: string;
+        /**
+          * An optional span that indicates the text to be replaced by this completion item. It will be
+          * set if the required span differs from the one generated by the default replacement behavior and should
+          * be used in that case
+          */
         replacementSpan?: TextSpan;
     }
 
