Don't consider x. a new identifier location just because x has a number index signature (microsoft#24699)

Andy · web-flow · commit 83c58a4fb5ea · 2018-06-07T12:05:47.000-07:00
* Don't consider `x.` a new identifier location just because x has a number index signature

* Update more tests
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -1074,7 +1074,7 @@ namespace ts.Completions {
         }
 
         function addTypeProperties(type: Type): void {
-            isNewIdentifierLocation = hasIndexSignature(type);
+            isNewIdentifierLocation = !!type.getStringIndexType();
 
             if (isUncheckedFile) {
                 // In javascript files, for union types, we don't just get the members that
diff --git a/tests/cases/fourslash/completionListAfterStringLiteral1.ts b/tests/cases/fourslash/completionListAfterStringLiteral1.ts
@@ -2,6 +2,10 @@
 
 ////"a"./**/
 
-goTo.marker();
-verify.not.completionListContains('alert');
-verify.completionListContains('charAt');
+verify.completions({
+    marker: "",
+    exact: [
+        "toString", "charAt", "charCodeAt", "concat", "indexOf", "lastIndexOf", "localeCompare", "match", "replace", "search", "slice",
+        "split", "substring", "toLowerCase", "toLocaleLowerCase", "toUpperCase", "toLocaleUpperCase", "trim", "length", "substr", "valueOf",
+    ],
+});
diff --git a/tests/cases/fourslash/getJavaScriptCompletions12.ts b/tests/cases/fourslash/getJavaScriptCompletions12.ts
@@ -24,7 +24,7 @@
 ////var test1 = function(x) { return x./*4*/ }, test2 = function(a) { return a./*5*/ };
 
 verify.completions(
-    { marker: "1", includes: { name: "charCodeAt", kind: "method" }, isNewIdentifierLocation: true },
+    { marker: "1", includes: { name: "charCodeAt", kind: "method" } },
     { marker: ["2", "3", "4"], includes: { name: "toExponential", kind: "method" } },
     { marker: "5", includes: { name: "test1", kind: "warning" } },
 );
diff --git a/tests/cases/fourslash/javaScriptClass1.ts b/tests/cases/fourslash/javaScriptClass1.ts
@@ -22,7 +22,7 @@ edit.insert('.');
 verify.completions({ exact: ["bar", "thing", "union", "Foo", "x"] });
 
 edit.insert('bar.');
-verify.completions({ includes: ["substr"], isNewIdentifierLocation: true });
+verify.completions({ includes: ["substr"] });
 edit.backspace('bar.'.length);
 
 edit.insert('union.');

Original file line number	Diff line number	Diff line change
`@@ -1074,7 +1074,7 @@ namespace ts.Completions {`
`1074`	`1074`	`}`
`1075`	`1075`
`1076`	`1076`	`function addTypeProperties(type: Type): void {`
`1077`		`- isNewIdentifierLocation = hasIndexSignature(type);`
	`1077`	`+ isNewIdentifierLocation = !!type.getStringIndexType();`
`1078`	`1078`
`1079`	`1079`	`if (isUncheckedFile) {`
`1080`	`1080`	`// In javascript files, for union types, we don't just get the members that`