[Release-2.0] Fix 9782: do not report blocked-scope-used-before-declaration error in ambient context (microsoft#9789) (microsoft#9830)

yuit · web-flow · commit 80db0f2f166d · 2016-07-19T15:16:27.000-07:00
* Do not report block-scoped-used-before-declaration in ambient context

* Add tests and baselines
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -974,7 +974,7 @@ namespace ts {
 
             Debug.assert(declaration !== undefined, "Block-scoped variable declaration is undefined");
 
-            if (!isBlockScopedNameDeclaredBeforeUse(<Declaration>getAncestor(declaration, SyntaxKind.VariableDeclaration), errorLocation)) {
+            if (!isInAmbientContext(declaration) && !isBlockScopedNameDeclaredBeforeUse(<Declaration>getAncestor(declaration, SyntaxKind.VariableDeclaration), errorLocation)) {
                 error(errorLocation, Diagnostics.Block_scoped_variable_0_used_before_its_declaration, declarationNameToString(declaration.name));
             }
         }
diff --git a/tests/baselines/reference/noUsedBeforeDefinedErrorInAmbientContext1.symbols b/tests/baselines/reference/noUsedBeforeDefinedErrorInAmbientContext1.symbols
@@ -0,0 +1,9 @@
+=== tests/cases/compiler/test.d.ts ===
+
+declare var S: typeof A; // no error
+>S : Symbol(S, Decl(test.d.ts, 1, 11))
+>A : Symbol(A, Decl(test.d.ts, 2, 13))
+
+declare const A: number;  
+>A : Symbol(A, Decl(test.d.ts, 2, 13))
+
diff --git a/tests/baselines/reference/noUsedBeforeDefinedErrorInAmbientContext1.types b/tests/baselines/reference/noUsedBeforeDefinedErrorInAmbientContext1.types
@@ -0,0 +1,9 @@
+=== tests/cases/compiler/test.d.ts ===
+
+declare var S: typeof A; // no error
+>S : number
+>A : number
+
+declare const A: number;  
+>A : number
+
diff --git a/tests/cases/compiler/noUsedBeforeDefinedErrorInAmbientContext1.ts b/tests/cases/compiler/noUsedBeforeDefinedErrorInAmbientContext1.ts
@@ -0,0 +1,4 @@
+﻿// @filename: test.d.ts
+
+declare var S: typeof A; // no error
+declare const A: number;  

Original file line number	Diff line number	Diff line change
`@@ -974,7 +974,7 @@ namespace ts {`
`974`	`974`
`975`	`975`	`Debug.assert(declaration !== undefined, "Block-scoped variable declaration is undefined");`
`976`	`976`
`977`		`- if (!isBlockScopedNameDeclaredBeforeUse(<Declaration>getAncestor(declaration, SyntaxKind.VariableDeclaration), errorLocation)) {`
	`977`	`+ if (!isInAmbientContext(declaration) && !isBlockScopedNameDeclaredBeforeUse(<Declaration>getAncestor(declaration, SyntaxKind.VariableDeclaration), errorLocation)) {`
`978`	`978`	`error(errorLocation, Diagnostics.Block_scoped_variable_0_used_before_its_declaration, declarationNameToString(declaration.name));`
`979`	`979`	`}`
`980`	`980`	`}`