Merge pull request microsoft#10391 from Microsoft/SetIsNewIdentifierLocationToTrueForJS

jramsay · web-flow · commit 7a9f8c8798a4 · 2016-08-17T13:58:21.000-07:00
Set isNewIdentifierLocation to true for JavaScript files
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -4248,7 +4248,7 @@ namespace ts {
                 addRange(entries, keywordCompletions);
             }
 
-            return { isMemberCompletion, isNewIdentifierLocation, entries };
+            return { isMemberCompletion, isNewIdentifierLocation: isNewIdentifierLocation || isSourceFileJavaScript(sourceFile), entries };
 
             function getJavaScriptCompletionEntries(sourceFile: SourceFile, position: number, uniqueNames: Map<string>): CompletionEntry[] {
                 const entries: CompletionEntry[] = [];

Original file line number	Diff line number	Diff line change
`@@ -4248,7 +4248,7 @@ namespace ts {`
`4248`	`4248`	`addRange(entries, keywordCompletions);`
`4249`	`4249`	`}`
`4250`	`4250`
`4251`		`- return { isMemberCompletion, isNewIdentifierLocation, entries };`
	`4251`	`+ return { isMemberCompletion, isNewIdentifierLocation: isNewIdentifierLocation \|\| isSourceFileJavaScript(sourceFile), entries };`
`4252`	`4252`
`4253`	`4253`	`function getJavaScriptCompletionEntries(sourceFile: SourceFile, position: number, uniqueNames: Map<string>): CompletionEntry[] {`
`4254`	`4254`	`const entries: CompletionEntry[] = [];`