Add more detailed error message

sandersn · sandersn · commit 79f09dab4f6e · 2015-10-30T09:16:10.000-07:00
When an object literal, for example, is returned that does not match the
type of the consturctor, add detail about a field that is required but
missing.

Do this by passing `node.expression` instead of `undefined` -- the rest of
the error reporting infrastructure is already in place.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -12647,7 +12647,7 @@ namespace ts {
                         error(node.expression, Diagnostics.Setters_cannot_return_a_value);
                     }
                     else if (func.kind === SyntaxKind.Constructor) {
-                        if (!isTypeAssignableTo(exprType, returnType)) {
+                        if (!checkTypeAssignableTo(exprType, returnType, node.expression)) {
                             error(node.expression, Diagnostics.Return_type_of_constructor_signature_must_be_assignable_to_the_instance_type_of_the_class);
                         }
                     }

Original file line number	Diff line number	Diff line change
`@@ -12647,7 +12647,7 @@ namespace ts {`
`12647`	`12647`	`error(node.expression, Diagnostics.Setters_cannot_return_a_value);`
`12648`	`12648`	`}`
`12649`	`12649`	`else if (func.kind === SyntaxKind.Constructor) {`
`12650`		`- if (!isTypeAssignableTo(exprType, returnType)) {`
	`12650`	`+ if (!checkTypeAssignableTo(exprType, returnType, node.expression)) {`
`12651`	`12651`	`error(node.expression, Diagnostics.Return_type_of_constructor_signature_must_be_assignable_to_the_instance_type_of_the_class);`
`12652`	`12652`	`}`
`12653`	`12653`	`}`