no-unused-expressions: [error, { allowTernary: true }]

a-tarasyuk · a-tarasyuk · commit 78d8e80330d1 · 2019-08-08T21:48:54.000+03:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -92,7 +92,7 @@
         "no-trailing-spaces": "error",
         "no-undef-init": "error",
         "no-unsafe-finally": "error",
-        "no-unused-expressions": "error",
+        "no-unused-expressions": ["error", { "allowTernary": true }],
         "no-unused-labels": "error",
         "no-var": "error",
         "object-shorthand": "error",
diff --git a/src/services/refactors/generateGetAccessorAndSetAccessor.ts b/src/services/refactors/generateGetAccessorAndSetAccessor.ts
@@ -214,17 +214,9 @@ namespace ts.refactor.generateGetAccessorAndSetAccessor {
     }
 
     function insertAccessor(changeTracker: textChanges.ChangeTracker, file: SourceFile, accessor: AccessorDeclaration, declaration: AcceptedDeclaration, container: ContainerDeclaration) {
-        if (isParameterPropertyDeclaration(declaration)) {
-            changeTracker.insertNodeAtClassStart(file, <ClassLikeDeclaration>container, accessor);
-        }
-        else {
-            if (isPropertyAssignment(declaration)) {
-                changeTracker.insertNodeAfterComma(file, declaration, accessor);
-            }
-            else {
-                changeTracker.insertNodeAfter(file, declaration, accessor);
-            }
-        }
+        isParameterPropertyDeclaration(declaration) ? changeTracker.insertNodeAtClassStart(file, <ClassLikeDeclaration>container, accessor) :
+            isPropertyAssignment(declaration) ? changeTracker.insertNodeAfterComma(file, declaration, accessor) :
+            changeTracker.insertNodeAfter(file, declaration, accessor);
     }
 
     function updateReadonlyPropertyInitializerStatementConstructor(changeTracker: textChanges.ChangeTracker, file: SourceFile, constructor: ConstructorDeclaration, fieldName: string, originalName: string) {
