compile vs tslints services dts, null check lint

weswigham · weswigham · commit 7813121c4d77 · 2015-08-25T18:37:52.000-07:00
diff --git a/Jakefile.js b/Jakefile.js
@@ -773,7 +773,8 @@ task("update-sublime", ["local", serverFile], function() {
 var tslintRuleDir = "scripts/tslint";
 var tslintRules = ([
     "nextLineRule",
-    "noInferrableTypesRule"
+    "noInferrableTypesRule",
+    "noNullRule"
 ]);
 var tslintRulesFiles = tslintRules.map(function(p) {
     return path.join(tslintRuleDir, p + ".ts");
diff --git a/scripts/tslint/nextLineRule.ts b/scripts/tslint/nextLineRule.ts
@@ -1,4 +1,4 @@
-/// <reference path="../../lib/typescriptServices.d.ts" />
+/// <reference path="../../node_modules/tslint/typings/typescriptServices.d.ts" />
 /// <reference path="../../node_modules/tslint/lib/tslint.d.ts" />
 
 const OPTION_CATCH = "check-catch";
diff --git a/scripts/tslint/noInferrableTypesRule.ts b/scripts/tslint/noInferrableTypesRule.ts
@@ -1,4 +1,4 @@
-/// <reference path="../../lib/typescriptServices.d.ts" />
+/// <reference path="../../node_modules/tslint/typings/typescriptServices.d.ts" />
 /// <reference path="../../node_modules/tslint/lib/tslint.d.ts" />
 
 
diff --git a/scripts/tslint/noNullRule.ts b/scripts/tslint/noNullRule.ts
@@ -0,0 +1,20 @@
+/// <reference path="../../node_modules/tslint/typings/typescriptServices.d.ts" />
+/// <reference path="../../node_modules/tslint/lib/tslint.d.ts" />
+
+
+export class Rule extends Lint.Rules.AbstractRule {
+    public static FAILURE_STRING = "Don't use the 'null' keyword - use 'undefined' for missing values instead";
+
+    public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
+        return this.applyWithWalker(new NullWalker(sourceFile, this.getOptions()));
+    }
+}
+
+class NullWalker extends Lint.RuleWalker {
+    visitNode(node: ts.Node) {
+        super.visitNode(node);
+        if (node.kind === ts.SyntaxKind.NullKeyword) {
+            this.addFailure(this.createFailure(node.getStart(), node.getWidth(), Rule.FAILURE_STRING));
+        }
+    }
+}
diff --git a/tslint.json b/tslint.json
@@ -38,6 +38,7 @@
         ],
         "no-internal-module": true,
         "no-trailing-whitespace": true,
-        "no-inferrable-types": true
+        "no-inferrable-types": true,
+        "no-null": true
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/// <reference path="../../lib/typescriptServices.d.ts" />`
	`1`	`+/// <reference path="../../node_modules/tslint/typings/typescriptServices.d.ts" />`
`2`	`2`	`/// <reference path="../../node_modules/tslint/lib/tslint.d.ts" />`
`3`	`3`
`4`	`4`	`const OPTION_CATCH = "check-catch";`
Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,7 @@`
`38`	`38`	`],`
`39`	`39`	`"no-internal-module": true,`
`40`	`40`	`"no-trailing-whitespace": true,`
`41`		`- "no-inferrable-types": true`
	`41`	`+ "no-inferrable-types": true,`
	`42`	`+ "no-null": true`
`42`	`43`	`}`
`43`	`44`	`}`