Merge pull request microsoft#12862 from Microsoft/neater_checker

Andy · web-flow · commit 757af496e176 · 2016-12-14T07:48:40.000-08:00
Make some code in checker neater
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -466,9 +466,7 @@ namespace ts {
                     // other kinds of value declarations take precedence over modules
                     target.valueDeclaration = source.valueDeclaration;
                 }
-                forEach(source.declarations, node => {
-                    target.declarations.push(node);
-                });
+                addRange(target.declarations, source.declarations);
                 if (source.members) {
                     if (!target.members) target.members = createMap<Symbol>();
                     mergeSymbolTable(target.members, source.members);
@@ -1100,7 +1098,7 @@ namespace ts {
         }
 
         function getDeclarationOfAliasSymbol(symbol: Symbol): Declaration | undefined {
-            return forEach(symbol.declarations, d => isAliasSymbolDeclaration(d) ? d : undefined);
+            return find<Declaration>(symbol.declarations, isAliasSymbolDeclaration);
         }
 
         function getTargetOfImportEqualsDeclaration(node: ImportEqualsDeclaration): Symbol {

Original file line number	Diff line number	Diff line change
`@@ -466,9 +466,7 @@ namespace ts {`
`466`	`466`	`// other kinds of value declarations take precedence over modules`
`467`	`467`	`target.valueDeclaration = source.valueDeclaration;`
`468`	`468`	`}`
`469`		`- forEach(source.declarations, node => {`
`470`		`- target.declarations.push(node);`
`471`		`- });`
	`469`	`+ addRange(target.declarations, source.declarations);`
`472`	`470`	`if (source.members) {`
`473`	`471`	`if (!target.members) target.members = createMap<Symbol>();`
`474`	`472`	`mergeSymbolTable(target.members, source.members);`
`@@ -1100,7 +1098,7 @@ namespace ts {`
`1100`	`1098`	`}`
`1101`	`1099`
`1102`	`1100`	`function getDeclarationOfAliasSymbol(symbol: Symbol): Declaration \| undefined {`
`1103`		`- return forEach(symbol.declarations, d => isAliasSymbolDeclaration(d) ? d : undefined);`
	`1101`	`+ return find<Declaration>(symbol.declarations, isAliasSymbolDeclaration);`
`1104`	`1102`	`}`
`1105`	`1103`
`1106`	`1104`	`function getTargetOfImportEqualsDeclaration(node: ImportEqualsDeclaration): Symbol {`