Implemented getOccurrences for 'constructor' keywords.

DanielRosenwasser · DanielRosenwasser · commit 6cc0305a5d32 · 2014-09-09T14:54:19.000-07:00
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -2185,6 +2185,11 @@ module ts {
                         return getBreakStatementOccurences(<BreakOrContinueStatement>node.parent);
                     }
                     break;
+                case SyntaxKind.ConstructorKeyword:
+                    if (hasKind(node.parent, SyntaxKind.Constructor)) {
+                        return getConstructorOccurrences(<ConstructorDeclaration>node.parent);
+                    }
+                    break;
             }
 
             return undefined;
@@ -2249,7 +2254,7 @@ module ts {
                 return result;
             }
 
-            function getReturnOccurrences(returnStatement: ReturnStatement): ReferenceEntry[]{
+            function getReturnOccurrences(returnStatement: ReturnStatement): ReferenceEntry[] {
                 var func = <FunctionDeclaration>getContainingFunction(returnStatement);
 
                 // If we didn't find a containing function with a block body, bail out.
@@ -2317,7 +2322,7 @@ module ts {
                 return map(keywords, getReferenceEntryFromNode);
             }
 
-            function getBreakStatementOccurences(breakStatement: BreakOrContinueStatement): ReferenceEntry[]{
+            function getBreakStatementOccurences(breakStatement: BreakOrContinueStatement): ReferenceEntry[] {
                 // TODO (drosen): Deal with labeled statements.
                 if (breakStatement.label) {
                     return undefined;
@@ -2345,6 +2350,20 @@ module ts {
                 return undefined;
             }
 
+            function getConstructorOccurrences(constructorDeclaration: ConstructorDeclaration): ReferenceEntry[] {
+                var declarations = constructorDeclaration.symbol.getDeclarations()
+
+                var keywords: Node[] = [];
+
+                forEach(declarations, declaration => {
+                    forEach(declaration.getChildren(), token => {
+                        return pushKeywordIf(keywords, token, SyntaxKind.ConstructorKeyword);
+                    });
+                });
+
+                return map(keywords, getReferenceEntryFromNode);
+            }
+
             // returns true if 'node' is defined and has a matching 'kind'.
             function hasKind(node: Node, kind: SyntaxKind) {
                 return !!(node && node.kind === kind);
diff --git a/tests/cases/fourslash/getOccurrencesConstructor.ts b/tests/cases/fourslash/getOccurrencesConstructor.ts
@@ -0,0 +1,32 @@
+/// <reference path='fourslash.ts' />
+
+////class C {
+////    [|const/**/ructor|]();
+////    [|constructor|](x: number);
+////    [|constructor|](y: string, x: number);
+////    [|constructor|](a?: any, ...r: any[]) {
+////        if (a === undefined && r.length === 0) {
+////            return;
+////        }
+////
+////        return;
+////    }
+////}
+////
+////class D {
+////    constructor(public x: number, public y: number) {
+////    }
+////}
+
+test.ranges().forEach(r => {
+    goTo.position(r.start);
+
+    test.ranges().forEach(range => {
+        verify.occurrencesAtPositionContains(range, false);
+    });
+});
+
+goTo.marker();
+test.ranges().forEach(range => {
+    verify.occurrencesAtPositionContains(range, false);
+});
diff --git a/tests/cases/fourslash/getOccurrencesConstructor2.ts b/tests/cases/fourslash/getOccurrencesConstructor2.ts
@@ -0,0 +1,32 @@
+/// <reference path='fourslash.ts' />
+
+////class C {
+////    constructor();
+////    constructor(x: number);
+////    constructor(y: string, x: number);
+////    constructor(a?: any, ...r: any[]) {
+////        if (a === undefined && r.length === 0) {
+////            return;
+////        }
+////
+////        return;
+////    }
+////}
+////
+////class D {
+////    [|con/**/structor|](public x: number, public y: number) {
+////    }
+////}
+
+test.ranges().forEach(r => {
+    goTo.position(r.start);
+
+    test.ranges().forEach(range => {
+        verify.occurrencesAtPositionContains(range, false);
+    });
+});
+
+goTo.marker();
+test.ranges().forEach(range => {
+    verify.occurrencesAtPositionContains(range, false);
+});
