Set use flag (microsoft#24881)

weswigham · web-flow · commit 6c78ce31ead3 · 2018-06-11T17:00:17.000-07:00
diff --git a/src/services/signatureHelp.ts b/src/services/signatureHelp.ts
@@ -366,7 +366,7 @@ namespace ts.SignatureHelp {
         return invocation.kind === InvocationKind.Call ? getInvokedExpression(invocation.node) : invocation.called;
     }
 
-    const signatureHelpNodeBuilderFlags = NodeBuilderFlags.OmitParameterModifiers | NodeBuilderFlags.IgnoreErrors;
+    const signatureHelpNodeBuilderFlags = NodeBuilderFlags.OmitParameterModifiers | NodeBuilderFlags.IgnoreErrors | NodeBuilderFlags.UseAliasDefinedOutsideCurrentScope;
     function createSignatureHelpItems(candidates: ReadonlyArray<Signature>, resolvedSignature: Signature, argumentListInfo: ArgumentListInfo, sourceFile: SourceFile, typeChecker: TypeChecker): SignatureHelpItems {
         const { argumentCount, argumentsSpan: applicableSpan, invocation, argumentIndex } = argumentListInfo;
         const isTypeParameterList = argumentListInfo.kind === ArgumentListKind.TypeArguments;
diff --git a/tests/cases/fourslash/signatureHelpForNonlocalTypeDoesNotUseImportType.ts b/tests/cases/fourslash/signatureHelpForNonlocalTypeDoesNotUseImportType.ts
@@ -0,0 +1,15 @@
+/// <reference path="fourslash.ts" />
+
+// @Filename: exporter.ts
+////export interface Thing {}
+////export const Foo: () => Thing = null as any;
+
+// @Filename: usage.ts
+////import {Foo} from "./exporter"
+////function f(p = Foo()): void {}
+////f(/*1*/
+
+verify.signatureHelp({
+    marker: "1",
+    text: "f(p?: Thing): void"
+});

Original file line number	Diff line number	Diff line change
`@@ -366,7 +366,7 @@ namespace ts.SignatureHelp {`
`366`	`366`	`return invocation.kind === InvocationKind.Call ? getInvokedExpression(invocation.node) : invocation.called;`
`367`	`367`	`}`
`368`	`368`
`369`		`- const signatureHelpNodeBuilderFlags = NodeBuilderFlags.OmitParameterModifiers \| NodeBuilderFlags.IgnoreErrors;`
	`369`	`+ const signatureHelpNodeBuilderFlags = NodeBuilderFlags.OmitParameterModifiers \| NodeBuilderFlags.IgnoreErrors \| NodeBuilderFlags.UseAliasDefinedOutsideCurrentScope;`
`370`	`370`	`function createSignatureHelpItems(candidates: ReadonlyArray<Signature>, resolvedSignature: Signature, argumentListInfo: ArgumentListInfo, sourceFile: SourceFile, typeChecker: TypeChecker): SignatureHelpItems {`
`371`	`371`	`const { argumentCount, argumentsSpan: applicableSpan, invocation, argumentIndex } = argumentListInfo;`
`372`	`372`	`const isTypeParameterList = argumentListInfo.kind === ArgumentListKind.TypeArguments;`