Skip to content

Commit 6b1cc89

Browse files
author
Andy Hanson
committed
Use native maps when they're available
1 parent 2166364 commit 6b1cc89

80 files changed

Lines changed: 1117 additions & 949 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎scripts/processDiagnosticMessages.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ function main(): void {
2727

2828
var inputFilePath = sys.args[0].replace(/\\/g, "/");
2929
var inputStr = sys.readFile(inputFilePath);
30-
30+
3131
var diagnosticMessages: InputDiagnosticMessageTable = JSON.parse(inputStr);
3232

3333
var names = Utilities.getObjectKeys(diagnosticMessages);
@@ -44,7 +44,7 @@ function main(): void {
4444
function checkForUniqueCodes(messages: string[], diagnosticTable: InputDiagnosticMessageTable) {
4545
const originalMessageForCode: string[] = [];
4646
let numConflicts = 0;
47-
47+
4848
for (const currentMessage of messages) {
4949
const code = diagnosticTable[currentMessage].code;
5050

@@ -74,7 +74,7 @@ function buildUniqueNameMap(names: string[]): ts.Map<string> {
7474
var uniqueNames = NameGenerator.ensureUniqueness(names, /* isCaseSensitive */ false, /* isFixed */ undefined);
7575

7676
for (var i = 0; i < names.length; i++) {
77-
nameMap[names[i]] = uniqueNames[i];
77+
nameMap.set(names[i], uniqueNames[i]);
7878
}
7979

8080
return nameMap;
@@ -91,7 +91,7 @@ function buildInfoFileOutput(messageTable: InputDiagnosticMessageTable, nameMap:
9191
for (var i = 0; i < names.length; i++) {
9292
var name = names[i];
9393
var diagnosticDetails = messageTable[name];
94-
var propName = convertPropertyName(nameMap[name]);
94+
var propName = convertPropertyName(nameMap.get(name));
9595

9696
result +=
9797
' ' + propName +
@@ -114,7 +114,7 @@ function buildDiagnosticMessageOutput(messageTable: InputDiagnosticMessageTable,
114114
for (var i = 0; i < names.length; i++) {
115115
var name = names[i];
116116
var diagnosticDetails = messageTable[name];
117-
var propName = convertPropertyName(nameMap[name]);
117+
var propName = convertPropertyName(nameMap.get(name));
118118

119119
result += '\r\n "' + createKey(propName, diagnosticDetails.code) + '"' + ' : "' + name.replace(/[\"]/g, '\\"') + '"';
120120
if (i !== names.length - 1) {

‎src/compiler/binder.ts‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -349,17 +349,17 @@ namespace ts {
349349
// Otherwise, we'll be merging into a compatible existing symbol (for example when
350350
// you have multiple 'vars' with the same name in the same container). In this case
351351
// just add this node into the declarations list of the symbol.
352-
symbol = symbolTable[name] || (symbolTable[name] = createSymbol(SymbolFlags.None, name));
352+
symbol = symbolTable.get(name) || set(symbolTable, name, createSymbol(SymbolFlags.None, name));
353353

354354
if (name && (includes & SymbolFlags.Classifiable)) {
355-
classifiableNames[name] = name;
355+
classifiableNames.set(name, name);
356356
}
357357

358358
if (symbol.flags & excludes) {
359359
if (symbol.isReplaceableByMethod) {
360360
// Javascript constructor-declared symbols can be discarded in favor of
361361
// prototype symbols like methods.
362-
symbol = symbolTable[name] = createSymbol(SymbolFlags.None, name);
362+
symbol = set(symbolTable, name, createSymbol(SymbolFlags.None, name));
363363
}
364364
else {
365365
if (node.name) {
@@ -1570,7 +1570,7 @@ namespace ts {
15701570
const typeLiteralSymbol = createSymbol(SymbolFlags.TypeLiteral, "__type");
15711571
addDeclarationToSymbol(typeLiteralSymbol, node, SymbolFlags.TypeLiteral);
15721572
typeLiteralSymbol.members = createMap<Symbol>();
1573-
typeLiteralSymbol.members[symbol.name] = symbol;
1573+
typeLiteralSymbol.members.set(symbol.name, symbol);
15741574
}
15751575

15761576
function bindObjectLiteralExpression(node: ObjectLiteralExpression) {
@@ -1601,9 +1601,9 @@ namespace ts {
16011601
? ElementKind.Property
16021602
: ElementKind.Accessor;
16031603

1604-
const existingKind = seen[identifier.text];
1604+
const existingKind = seen.get(identifier.text);
16051605
if (!existingKind) {
1606-
seen[identifier.text] = currentKind;
1606+
seen.set(identifier.text, currentKind);
16071607
continue;
16081608
}
16091609

@@ -2208,7 +2208,7 @@ namespace ts {
22082208
constructorFunction.parent = classPrototype;
22092209
classPrototype.parent = leftSideOfAssignment;
22102210

2211-
const funcSymbol = container.locals[constructorFunction.text];
2211+
const funcSymbol = container.locals.get(constructorFunction.text);
22122212
if (!funcSymbol || !(funcSymbol.flags & SymbolFlags.Function || isDeclarationOfFunctionExpression(funcSymbol))) {
22132213
return;
22142214
}
@@ -2239,7 +2239,7 @@ namespace ts {
22392239
bindAnonymousDeclaration(node, SymbolFlags.Class, bindingName);
22402240
// Add name of class expression into the map for semantic classifier
22412241
if (node.name) {
2242-
classifiableNames[node.name.text] = node.name.text;
2242+
classifiableNames.set(node.name.text, node.name.text);
22432243
}
22442244
}
22452245

@@ -2255,14 +2255,14 @@ namespace ts {
22552255
// module might have an exported variable called 'prototype'. We can't allow that as
22562256
// that would clash with the built-in 'prototype' for the class.
22572257
const prototypeSymbol = createSymbol(SymbolFlags.Property | SymbolFlags.Prototype, "prototype");
2258-
if (symbol.exports[prototypeSymbol.name]) {
2258+
const symbolExport = symbol.exports.get(prototypeSymbol.name);
2259+
if (symbolExport) {
22592260
if (node.name) {
22602261
node.name.parent = node;
22612262
}
2262-
file.bindDiagnostics.push(createDiagnosticForNode(symbol.exports[prototypeSymbol.name].declarations[0],
2263-
Diagnostics.Duplicate_identifier_0, prototypeSymbol.name));
2263+
file.bindDiagnostics.push(createDiagnosticForNode(symbolExport.declarations[0], Diagnostics.Duplicate_identifier_0, prototypeSymbol.name));
22642264
}
2265-
symbol.exports[prototypeSymbol.name] = prototypeSymbol;
2265+
symbol.exports.set(prototypeSymbol.name, prototypeSymbol);
22662266
prototypeSymbol.parent = symbol;
22672267
}
22682268

0 commit comments

Comments
 (0)