Skip arrow functions in checkAndReportErrorForMissingPrefix (microsoft#23584)

Andy · web-flow · commit 699ea246ffbc · 2018-04-20T15:02:18.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -1568,7 +1568,7 @@ namespace ts {
                 return false;
             }
 
-            const container = getThisContainer(errorLocation, /*includeArrowFunctions*/ true);
+            const container = getThisContainer(errorLocation, /*includeArrowFunctions*/ false);
             let location = container;
             while (location) {
                 if (isClassLike(location.parent)) {
diff --git a/tests/baselines/reference/classMemberInitializerWithLamdaScoping4.errors.txt b/tests/baselines/reference/classMemberInitializerWithLamdaScoping4.errors.txt
@@ -1,4 +1,4 @@
-tests/cases/compiler/classMemberInitializerWithLamdaScoping3_1.ts(8,21): error TS2304: Cannot find name 'field1'.
+tests/cases/compiler/classMemberInitializerWithLamdaScoping3_1.ts(8,21): error TS2663: Cannot find name 'field1'. Did you mean the instance member 'this.field1'?
 
 
 ==== tests/cases/compiler/classMemberInitializerWithLamdaScoping3_0.ts (0 errors) ====
@@ -14,6 +14,6 @@ tests/cases/compiler/classMemberInitializerWithLamdaScoping3_1.ts(8,21): error T
         messageHandler = () => {
             console.log(field1); // Should be error that couldnt find symbol field1
                         ~~~~~~
-!!! error TS2304: Cannot find name 'field1'.
+!!! error TS2663: Cannot find name 'field1'. Did you mean the instance member 'this.field1'?
         };
     }

Original file line number	Diff line number	Diff line change
`@@ -1568,7 +1568,7 @@ namespace ts {`
`1568`	`1568`	`return false;`
`1569`	`1569`	`}`
`1570`	`1570`
`1571`		`- const container = getThisContainer(errorLocation, /includeArrowFunctions/ true);`
	`1571`	`+ const container = getThisContainer(errorLocation, /includeArrowFunctions/ false);`
`1572`	`1572`	`let location = container;`
`1573`	`1573`	`while (location) {`
`1574`	`1574`	`if (isClassLike(location.parent)) {`