PR feedback

Paul van Brenk · Paul van Brenk · commit 682f81257d34 · 2016-09-16T14:52:33.000-07:00
diff --git a/src/services/codefixes/codeFixProvider.ts b/src/services/codefixes/codeFixProvider.ts
@@ -9,7 +9,7 @@ namespace ts {
         errorCode: string;
         sourceFile: SourceFile;
         span: TextSpan;
-        checker: TypeChecker;
+        program: Program;
         newLineCharacter: string;
     }
 
@@ -27,24 +27,22 @@ namespace ts {
             });
         }
 
-        export class CodeFixProvider {
-            public static getSupportedErrorCodes() {
-                return Object.keys(codeFixes);
-            }
+        export function getSupportedErrorCodes() {
+            return Object.keys(codeFixes);
+        }
 
-            public getFixes(context: CodeFixContext): CodeAction[] {
-                const fixes = codeFixes[context.errorCode];
-                let allActions: CodeAction[] = [];
+        export function getFixes(context: CodeFixContext): CodeAction[] {
+            const fixes = codeFixes[context.errorCode];
+            let allActions: CodeAction[] = [];
 
-                forEach(fixes, f => {
-                    const actions = f.getCodeActions(context);
-                    if (actions && actions.length > 0) {
-                        allActions = allActions.concat(actions);
-                    }
-                });
+            forEach(fixes, f => {
+                const actions = f.getCodeActions(context);
+                if (actions && actions.length > 0) {
+                    allActions = allActions.concat(actions);
+                }
+            });
 
-                return allActions;
-            }
+            return allActions;
         }
     }
-}
+}
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -695,7 +695,7 @@ namespace ts {
     }
 
     export function getSupportedCodeFixes() {
-        return codefix.CodeFixProvider.getSupportedErrorCodes();
+        return codefix.getSupportedErrorCodes();
     }
 
     // Cache host information about script Should be refreshed
@@ -918,7 +918,6 @@ namespace ts {
         documentRegistry: DocumentRegistry = createDocumentRegistry(host.useCaseSensitiveFileNames && host.useCaseSensitiveFileNames(), host.getCurrentDirectory())): LanguageService {
 
         const syntaxTreeCache: SyntaxTreeCache = new SyntaxTreeCache(host);
-        const codeFixProvider: codefix.CodeFixProvider = new codefix.CodeFixProvider();
         let ruleProvider: formatting.RulesProvider;
         let program: Program;
         let lastProjectVersion: string;
@@ -1588,19 +1587,18 @@ namespace ts {
         function getCodeFixesAtPosition(fileName: string, start: number, end: number, errorCodes: string[]): CodeAction[] {
             synchronizeHostData();
             const sourceFile = getValidSourceFile(fileName);
-            const checker = program.getTypeChecker();
             let allFixes: CodeAction[] = [];
 
             forEach(errorCodes, error => {
                 const context = {
                     errorCode: error,
                     sourceFile: sourceFile,
                     span: { start, length: end - start },
-                    checker: checker,
+                    program: program,
                     newLineCharacter: getNewLineOrDefaultFromHost(host)
                 };
 
-                const fixes = codeFixProvider.getFixes(context);
+                const fixes = codefix.getFixes(context);
                 if (fixes) {
                     allFixes = allFixes.concat(fixes);
                 }
