Encorporting feedback

sheetalkamat · sheetalkamat · commit 65a48ca15daf · 2017-06-06T11:27:31.000-07:00
diff --git a/Gulpfile.ts b/Gulpfile.ts
@@ -745,7 +745,7 @@ declare module "convert-source-map" {
     export function fromSource(source: string, largeSource?: boolean): SourceMapConverter;
 }
 
-gulp.task("browserify", "Runs browserify on run.js to produce a file suitable for running tests in the browser", [servicesFile], (done) => {
+gulp.task("browserify", "Runs browserify on run.js to produce a file suitable for running tests in the browser", [servicesFile, run], (done) => {
     const testProject = tsc.createProject("src/harness/tsconfig.json", getCompilerSettings({ outFile: "../../built/local/bundle.js" }, /*useBuiltCompiler*/ true));
     return testProject.src()
         .pipe(newer("built/local/bundle.js"))
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -749,13 +749,9 @@ namespace ts.Completions {
         }
 
         function isContextTokenValueLocation(contextToken: Node) {
-            if (contextToken) {
-                const parentKind = contextToken.parent.kind;
-                switch (contextToken.kind) {
-                    case SyntaxKind.TypeOfKeyword:
-                        return parentKind === SyntaxKind.TypeQuery;
-                }
-            }
+            return contextToken &&
+                contextToken.kind === SyntaxKind.TypeOfKeyword &&
+                contextToken.parent.kind === SyntaxKind.TypeQuery;
         }
 
         function isContextTokenTypeLocation(contextToken: Node) {
diff --git a/tests/cases/fourslash/completionListWithMeanings.ts b/tests/cases/fourslash/completionListWithMeanings.ts
@@ -11,6 +11,7 @@
 ////var tt = /*valueExpr*/xx;
 ////var yy: /*typeExpr*/point = { x: 4, y: 3 + /*valueExprInObjectLiteral*/tt };
 ////var kk: m3.point3/*membertypeExpr*/ = m3.zz2/*membervalueExpr*/;
+////var zz = </*typeExpr2*/point>{ x: 4, y: 3 };
 
 const markers = test.markerNames();
 
@@ -37,6 +38,7 @@ const values: CompletionInfo[] = [
     ["xx", "var xx: number"],
     ["tt", "var tt: number"],
     ["yy", "var yy: point"],
+    ["zz", "var zz: point"],
     ["m2", "namespace m2"], // With no type side, allowed only in value
 ];
 

Original file line number	Diff line number	Diff line change
`@@ -745,7 +745,7 @@ declare module "convert-source-map" {`
`745`	`745`	`export function fromSource(source: string, largeSource?: boolean): SourceMapConverter;`
`746`	`746`	`}`
`747`	`747`
`748`		`-gulp.task("browserify", "Runs browserify on run.js to produce a file suitable for running tests in the browser", [servicesFile], (done) => {`
	`748`	`+gulp.task("browserify", "Runs browserify on run.js to produce a file suitable for running tests in the browser", [servicesFile, run], (done) => {`
`749`	`749`	`const testProject = tsc.createProject("src/harness/tsconfig.json", getCompilerSettings({ outFile: "../../built/local/bundle.js" }, /useBuiltCompiler/ true));`
`750`	`750`	`return testProject.src()`
`751`	`751`	`.pipe(newer("built/local/bundle.js"))`