Fix microsoft#21641, Add indirect location for default imports for synthetic defaults (microsoft#21703)

weswigham · web-flow · commit 65149063ed06 · 2018-02-07T15:04:37.000-08:00
diff --git a/src/services/importTracker.ts b/src/services/importTracker.ts
@@ -107,6 +107,11 @@ namespace ts.FindAllReferences {
                             if (namedBindings && namedBindings.kind === SyntaxKind.NamespaceImport) {
                                 handleNamespaceImport(direct, namedBindings.name);
                             }
+                            else if (isDefaultImport(direct)) {
+                                const sourceFileLike = getSourceFileLikeForImportDeclaration(direct);
+                                addIndirectUser(sourceFileLike); // Add a check for indirect uses to handle synthetic default imports
+                                directImports.push(direct);
+                            }
                             else {
                                 directImports.push(direct);
                             }
diff --git a/tests/cases/fourslash/esModuleInteropFindAllReferences.ts b/tests/cases/fourslash/esModuleInteropFindAllReferences.ts
@@ -0,0 +1,12 @@
+// @esModuleInterop: true
+
+// @Filename: /abc.d.ts
+////declare module "a" {
+////    export const [|x|]: number;
+////}
+
+// @Filename: /b.ts
+////import * as a from "a";
+////a.[|x|];
+
+verify.rangesReferenceEachOther();

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,11 @@ namespace ts.FindAllReferences {`
`107`	`107`	`if (namedBindings && namedBindings.kind === SyntaxKind.NamespaceImport) {`
`108`	`108`	`handleNamespaceImport(direct, namedBindings.name);`
`109`	`109`	`}`
	`110`	`+ else if (isDefaultImport(direct)) {`
	`111`	`+ const sourceFileLike = getSourceFileLikeForImportDeclaration(direct);`
	`112`	`+ addIndirectUser(sourceFileLike); // Add a check for indirect uses to handle synthetic default imports`
	`113`	`+ directImports.push(direct);`
	`114`	`+ }`
`110`	`115`	`else {`
`111`	`116`	`directImports.push(direct);`
`112`	`117`	`}`